Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: test-logs are written to third_party/$TEST/... #382

Open
hzeller opened this issue May 15, 2020 · 1 comment
Open

Cleanup: test-logs are written to third_party/$TEST/... #382

hzeller opened this issue May 15, 2020 · 1 comment

Comments

@hzeller
Copy link
Collaborator

@hzeller hzeller commented May 15, 2020

When running the regression, the resulting logs seem to end up in third_party/tests/$TEST/.... This of course is not unnoticed by git, so a git status shows a ton of non-added new files added.

To reproduce:

make
make regression
git status   # observe all the files

Build or test artifacts should never clutter the rest of the code-base (we should regard them as read-only in fact), so we should move them to some output directory in build/. Probably as simple as changing a path somewhere.
Good first issue.

@alaindargelas
Copy link
Collaborator

@alaindargelas alaindargelas commented May 15, 2020

Has to do with the way the batch scripts are generated for the tests that require to be run in batch mode, Google, Yosys...
The batch scripts are generated by this meta script: tests/create_batch_script.tcl, ran manually in the directory of the test, and the resulting batch script is checked in. Options can be added in the meta script to not generate the logs and slpp_ dirs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.