Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
refactor limit #32
refactor limit #32
Conversation
|
@dongweiming can you describe specific cases these changes support or improve? Some code samples of the cases would help a lot. |
|
I did a little looking at Django's limit implementation. While Django doesn't have a limit method and uses a getitem overload to handle to use array slice syntax for limiting, it doesn't produce a new queryset on limit. The supports some of the changes @dongweiming is suggesting in this refactor. @tomchristie, @ryananguiano, what are your thoughts? |
I don't think use
limit_countas a parameter is the best solution, after that, it might also passoffset,havingand so on, there are too many params@Vector919 @tomchristie please review, thanks!