Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Change entry for dry layout on RenderBox #5007

Merged
merged 9 commits into from Dec 11, 2020

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Nov 21, 2020

Breaking Change entry for flutter/flutter#70656

goderbauer added 3 commits Nov 21, 2020
++
++
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Maybe make all of the class/member references into links?

sfshaza2 and others added 6 commits Dec 3, 2020
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
@goderbauer
Copy link
Member Author

@goderbauer goderbauer commented Dec 7, 2020

@sfshaza2 Thanks for applying the suggestions.

@gspencergoog Fixed the other comment, PTAL.

Copy link
Contributor

@gspencergoog gspencergoog left a comment

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@goderbauer goderbauer merged commit c0c3852 into flutter:master Dec 11, 2020
3 checks passed
3 checks passed
WIP Ready for review
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@goderbauer goderbauer deleted the goderbauer:dryLayout branch Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.