Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encourage people to use the tarball #5013

Merged
merged 3 commits into from Nov 24, 2020
Merged

Encourage people to use the tarball #5013

merged 3 commits into from Nov 24, 2020

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Nov 23, 2020

This also changes the order so that "flutter doctor" is recommended before "flutter precache". Some users were running into a situation where they didn't have the Android SDK installed at the time they ran "flutter precache" and that failed for them.

This also changes the order so that "flutter doctor" is recommended before "flutter precache". Some users were running into a situation where they didn't have the Android SDK installed at the time they ran "flutter precache" and that failed for them.
@google-cla google-cla bot added the cla: yes label Nov 23, 2020
@Hixie
Copy link
Contributor Author

@Hixie Hixie commented Nov 23, 2020


_This is only suggested for advanced use cases._

You can also use git directly instead of downloading the prepared tarball. For example,

This comment has been minimized.

@christopherfujino

christopherfujino Nov 23, 2020
Contributor

Should we use something more generic like "archive" over "tarball"? I believe we use zip on mac and windows.

This comment has been minimized.

@Hixie

Hixie Nov 23, 2020
Author Contributor

done

$ git clone https://github.com/flutter/flutter.git -b stable
```

If you do this, you may also wish to pre-download development binaries that are included

This comment has been minimized.

@christopherfujino

christopherfujino Nov 23, 2020
Contributor

Should we insert another flutter doctor before flutter precache here? And/or general instructions about ensuring all system requirements are present before continuing.

This comment has been minimized.

@Hixie

Hixie Nov 23, 2020
Author Contributor

done

Apply review comments and add more detail.
Copy link
Contributor

@christopherfujino christopherfujino left a comment

LGTM with an additional tarball nit

@@ -111,6 +81,33 @@ process.
Once you have installed any missing dependencies, run the `flutter doctor`
command again to verify that you’ve set everything up correctly.

### Downloading straight from GitHub instead of using a tarball

This comment has been minimized.

@christopherfujino

christopherfujino Nov 23, 2020
Contributor

nit. tarball -> "prepared/pre-built archive"

This comment has been minimized.

@Hixie

Hixie Nov 23, 2020
Author Contributor

oops!

@Hixie Hixie merged commit cd2ed8d into master Nov 24, 2020
3 checks passed
3 checks passed
WIP Ready for review
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Hixie Hixie deleted the Hixie-patch-1 branch Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.