Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Documentation example of split doesn't work #40
Conversation
I'm wasn't super sure I was following your test functions so I just tested the observables by transforming them to and from arrays. Part of the problem is StringObservable.split() seems to always behave like String.split() limit 0 which trims excess empty strings at the end. There also doesn't seem to be a way to change the limit so at least the documentation needs to be updated to show this behavior. Changing the limit in testSplit() doesn't help which is why I went with the array tests. Limit -1 or even something like 6 should preserve the empty strings if you follow the normal String.split(). But that limit could be for something else. I didn't dive that deep in the test code.
It still failed because of different lengths. But now it should behave if they were actually equal.
I think I have a fix now.
It should pass all the current tests.
|
/cc @davidmoten |
|
Thanks for this and excuse the delay. I'll run some examples with this myself but it certainly does appear that their is a conflict of intent in the operator that you have probably sorted out. I'll get back to you next week as I'm on holiday. Cheers. |
|
Did this ever get resolved one way or the other? I guess I should have made an issue for it. |
|
#47 has a fresh implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I wasn't super sure I was following your test functions so I just tested the observables by transforming them to and from arrays.
Part of the problem is StringObservable.split() seems to always behave like String.split() limit 0 which trims excess empty strings at the end. There also doesn't seem to be a way to change the limit so at least the documentation needs to be updated to show this behavior.
Changing the limit in testSplit() doesn't help which is why I went with the array tests.
Limit -1 or even something like 6 should preserve the empty strings if you follow the normal String.split().
But that limit could be for something else. I didn't dive that deep in the test code.