feat(core): RootLayout option with api to fluidly handle dynamic layers#8980
Merged
NathanWalker merged 21 commits intoJan 29, 2021
Merged
Conversation
…eScript/NativeScript into feat/ns7-finishing-touches
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
Member
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
NathanWalker
pushed a commit
that referenced
this pull request
Feb 12, 2021
NathanWalker
pushed a commit
that referenced
this pull request
Feb 27, 2021
NathanWalker
pushed a commit
that referenced
this pull request
Feb 27, 2021
NathanWalker
pushed a commit
that referenced
this pull request
Mar 3, 2021
This was referenced Mar 3, 2021
NathanWalker
pushed a commit
that referenced
this pull request
Mar 5, 2021
NathanWalker
pushed a commit
that referenced
this pull request
Apr 2, 2021
NathanWalker
pushed a commit
that referenced
this pull request
Apr 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Write a bunch of frontend framework flavor code to handle dynamic layers.
What is the new behavior?
Take advantage of unified api to easily spawn layered views with animation controls and modify their zOrder/front/back with ease which works in all flavors without additional code.
For more context see from here onward (example walkthrough of similar techniques specific to angular however this PR boils down all complexity to elegant approach in core for all flavors to take advantage of similar creative view handling): https://youtu.be/khHtbeTLRMM?t=992