Wouldn t it be better to mutate only when setting the color? If all your activity indicators use the theme color no need to mutate anythin

Wouldn t it be better to mutate only when setting the color? If all your activity indicators use the theme color no need to mutate anythin

That is because an indicator's color can be changed multiple times depending on one's needs, resulting in pointless mutate() calls even though they have no appliance after first call. Initializing it once seemed good to me, but we can change it.

Then mark the indicator as mutated. Oersonnaly as I use theme color for indicators I see that PR as a perf lost. I understand the need but we should do it right and mutate only when needed

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Dimitris - Rafail Katsampas.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email email@example.com
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Then mark the indicator as mutated. Oersonnaly as I use theme color for indicators I see that PR as a perf lost. I understand the need but we should do it right and mutate only when needed

You are right! To be honest, I didn't consider theme-based indicators. I just committed few more changes that might make things better.