Skip to content

fix: rollback regexp eslint changes#9028

Merged
NathanaelA merged 3 commits into
NativeScript:masterfrom
Akylas:eslint_rollback
Nov 12, 2020
Merged

fix: rollback regexp eslint changes#9028
NathanaelA merged 3 commits into
NativeScript:masterfrom
Akylas:eslint_rollback

Conversation

@farfromrefug
Copy link
Copy Markdown
Collaborator

this fixes the regression discovered here #9017 (comment)

@CatchABus
Copy link
Copy Markdown
Contributor

@farfromrefug There had been test failures in automate app, so I took a deep look.
It seems that few promise changes have also broken few things.
What I discovered so far is these 2 lines:
https://github.com/NativeScript/NativeScript/blob/master/packages/core/ui/animation/animation-common.ts#L103
https://github.com/NativeScript/NativeScript/blob/master/packages/core/ui/animation/animation-common.ts#L110

Reverting those got rid of about 20 test failures.

@farfromrefug
Copy link
Copy Markdown
Collaborator Author

farfromrefug commented Nov 12, 2020

damn let me fix this
EDIT: @dimitrisrk done thanks. I thought those errors were already there :s

@farfromrefug
Copy link
Copy Markdown
Collaborator Author

automated app tests are running (still issues but not related to this)

@NathanaelA

This comment was marked as abuse.

@farfromrefug
Copy link
Copy Markdown
Collaborator Author

Thanks @NathanaelA sorry I broke it in the first place. Would nt be a good idea to have automated apps ran before merging any PR ? I know it is heavy but it really seems necessary

@NathanaelA

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants