Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix no-response bot. #65042

Merged
merged 1 commit into from Sep 2, 2020
Merged

Conversation

@kf6gpe
Copy link
Contributor

@kf6gpe kf6gpe commented Sep 1, 2020

Description

Per probot/no-response#25, we're not following the recommended syntax for the configuration file. While this may or may not fix the problem where the bot doesn't always close issues, we should be following the documentation for configuration.

Related Issues

probot/no-response#25 (None in flutter/flutter)

Tests

N/A

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • [X ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@kf6gpe kf6gpe added the team label Sep 1, 2020
@kf6gpe kf6gpe requested review from Hixie, zanderso, tvolkert and helinanever Sep 1, 2020
@googlebot googlebot added the cla: yes label Sep 1, 2020
@fluttergithubbot fluttergithubbot merged commit 414c0d8 into flutter:master Sep 2, 2020
19 checks passed
19 checks passed
Google testing Google testing passed!
Details
Linux analyze
Details
Linux build_tests
Details
Linux customer_testing
Details
Linux fuchsia_precache
Details
Linux hostonly_devicelab_tests
Details
WIP Ready for review
Details
Windows customer_testing
Details
Windows tool_tests
Details
analyze-linux Task Summary
Details
cla/google All necessary CLAs are signed
customer_testing-linux Task Summary
Details
customer_testing-macos Task Summary
Details
deploy_gallery-linux Task Summary
Details
deploy_gallery-macos Task Summary
Details
firebase_test_lab_tests-0-linux Task Summary
Details
firebase_test_lab_tests-1-linux Task Summary
Details
firebase_test_lab_tests-2_last-linux Task Summary
Details
flutter-build
Details
mingwandroid added a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.