Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Drop browser tests #455
Open
Drop browser tests #455
Conversation
Considering following conditions, it seems that there is no necessity for testing whether this module is working on browsers.
- IE10+ implements `new FormData()` and `append`
https://developer.mozilla.org/en-US/docs/Web/API/FormData
- JSDOM has own implementation of FormData APIs
https://github.com/jsdom/jsdom/tree/master/lib/jsdom/living/xhr
|
@takenspc Thanks for you interest. Do you mind to elaborate on the reason for this change? |
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Considering following conditions, it seems that there is no necessity for testing whether this module is working on browsers.
IE10+ implements
new FormData()andappendhttps://developer.mozilla.org/en-US/docs/Web/API/FormData
JSDOM has own implementation of FormData APIs
https://github.com/jsdom/jsdom/tree/master/lib/jsdom/living/xhr
Additionally, current browser tests still depend on phantom.js and tests actually fail without phantom.js. There is no reason to support phantom.js anymore.
https://travis-ci.org/form-data/form-data/jobs/648654832
This PR drops browser tests and reorganize tests related npm scripts.