Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42345: Fix hash implementation of typing.Literal #23383

Merged
merged 2 commits into from Nov 19, 2020

Conversation

uriyyo
Copy link
Member

@uriyyo uriyyo commented Nov 18, 2020

Fix hash implementation of typing.Literal.

Update docs regarding typing.Litaral caching.

Base implementation was done in PR #23294.

https://bugs.python.org/issue42345

Automerge-Triggered-By: GH:gvanrossum

@uriyyo
Copy link
Member Author

@uriyyo uriyyo commented Nov 18, 2020

@gvanrossum Should we add Misc/NEWS.d/next/ or skip news label can be used?

Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

LGTM. This probbly doesn't need a news item, it can share the news item from the original PR.

Lib/test/test_typing.py Outdated Show resolved Hide resolved
Lib/typing.py Show resolved Hide resolved
@gvanrossum gvanrossum changed the title bpo-42345: Fix hash implementation of a typing.Literal bpo-42345: Fix hash implementation of typing.Literal Nov 19, 2020
@gvanrossum gvanrossum added 🤖 automerge needs backport to 3.9 labels Nov 19, 2020
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 19, 2020

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington miss-islington merged commit 1b54077 into python:master Nov 19, 2020
10 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 19, 2020

Thanks @uriyyo for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 19, 2020
Fix hash implementation of `typing.Literal`.

Update docs regarding `typing.Litaral` caching.

Base implementation was done in PR pythonGH-23294.
(cherry picked from commit 1b54077)

Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Nov 19, 2020

GH-23408 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this issue Nov 19, 2020
Fix hash implementation of `typing.Literal`.

Update docs regarding `typing.Litaral` caching.

Base implementation was done in PR GH-23294.
(cherry picked from commit 1b54077)

Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>
NulAsh added a commit to NulAsh/cpython that referenced this issue Dec 9, 2020
adorilson pushed a commit to adorilson/cpython that referenced this issue Mar 13, 2021
Fix hash implementation of `typing.Literal`.

Update docs regarding `typing.Litaral` caching.

Base implementation was done in PR python#23294.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed 🤖 automerge skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants