Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Travis iwyu #208
Merged
Travis iwyu #208
Conversation
Assumes clang-7 to be in use.
A few more builds but it won't miss structural changes that involve travis by accident
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
=======================================
Coverage 95.60% 95.60%
=======================================
Files 35 35
Lines 3233 3233
=======================================
Hits 3091 3091
Misses 142 142
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Identify the Bug
Include and fwd declarations were inconsistent and often not present when needed (derived from upstream) or redundant.
Description of the Change
This change adds checks to travis using IWYU (see: https://include-what-you-use.org/ ) preventing this problems from happening transparently. It also fixes the current problems.
Alternate Designs
N/D. Leave as is.
Possible Drawbacks
Potential issues on less tested systems (currently no FreeBSD test on travis, nor Cygwin on Windows). Can be covered in the future with more testing through CI/CD.
Verification Process
Travis runs and Appveyor runs.
Release Notes
Added checks using IWYU (see: https://include-what-you-use.org/ ) to cleanup includes within the library.
Notes
The large number of commits is due to travis that forces a push for every test (to verify) and an issue with how clang/iwyu are packetized within ubuntu (which forced a tricky compilation within the travis script).
These changes will be squashed once moved to master.