This repository was archived by the owner on Jan 5, 2023. It is now read-only.
Untrusted data flow to external API #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-mc
force-pushed
the
untrusted-data-flow-to-external-api
branch
4 times, most recently
from
deebcfd to
dadf275
Compare
owen-mc
force-pushed
the
untrusted-data-flow-to-external-api
branch
from
dadf275 to
3217afa
Compare
owen-mc
force-pushed
the
untrusted-data-flow-to-external-api
branch
from
3217afa to
dec92c9
Compare
Contributor
Author
|
@lcartey if you have time you could try out this go version of "Untrusted data flow to external API" and give feedback before it's merged. |
Add "github.com/golang/mock/gomock", several packages under "github.com/stretchr/testify", £gotest.tools/assert", "k8s.io/client-go/testing" and "testing"
See github/codeql-go-team#219 for issue to model this better
owen-mc
force-pushed
the
untrusted-data-flow-to-external-api
branch
from
dec92c9 to
bf78189
Compare
smowton
approved these changes
Nov 26, 2020
Contributor
smowton
left a comment
smowton
left a comment
There was a problem hiding this comment.
Some minor things to attend to, mostly lgtm
ql/src/Security/CWE-020/ExternalAPIsUsedWithUntrustedData.qhelp
Outdated
Show resolved
Hide resolved
ql/src/Security/CWE-020/ExternalAPIsUsedWithUntrustedData.qhelp
Outdated
Show resolved
Hide resolved
ql/src/Security/CWE-020/ExternalAPIsUsedWithUntrustedData.qhelp
Outdated
Show resolved
Hide resolved
owen-mc
force-pushed
the
untrusted-data-flow-to-external-api
branch
from
1817d20 to
4d23cef
Compare
Co-authored-by: Chris Smowton <smowton@github.com>
owen-mc
force-pushed
the
untrusted-data-flow-to-external-api
branch
from
4d23cef to
0ee00d8
Compare
|
@rvermeulen I know you wrote something similar recently, do you want to take a look? |
shati-patel
reviewed
Nov 26, 2020
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Looks good! I've added relevant suggestions to all the places they're repeated, so apologies for the duplicated comments 🙈
There aren't any change notes yet, could you add them before this is merged?
ql/src/Security/CWE-020/ExternalAPIsUsedWithUntrustedData.qhelp
Outdated
Show resolved
Hide resolved
ql/src/Security/CWE-020/ExternalAPIsUsedWithUntrustedData.qhelp
Outdated
Show resolved
Hide resolved
ql/src/Security/CWE-020/ExternalAPIsUsedWithUntrustedData.qhelp
Outdated
Show resolved
Hide resolved
ql/src/Security/CWE-020/ExternalAPIsUsedWithUntrustedData.qhelp
Outdated
Show resolved
Hide resolved
ql/src/Security/CWE-020/ExternalAPIsUsedWithUntrustedData.qhelp
Outdated
Show resolved
Hide resolved
ql/src/Security/CWE-020/UntrustedDataToUnknownExternalAPI.qhelp
Outdated
Show resolved
Hide resolved
ql/src/Security/CWE-020/UntrustedDataToUnknownExternalAPI.qhelp
Outdated
Show resolved
Hide resolved
ql/src/Security/CWE-020/UntrustedDataToUnknownExternalAPI.qhelp
Outdated
Show resolved
Hide resolved
ql/src/Security/CWE-020/UntrustedDataToUnknownExternalAPI.qhelp
Outdated
Show resolved
Hide resolved
ql/src/Security/CWE-020/UntrustedDataToUnknownExternalAPI.qhelp
Outdated
Show resolved
Hide resolved
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
When the taint was in the receiver, we were excluding methods which return nothing or a boolean.
owen-mc
force-pushed
the
untrusted-data-flow-to-external-api
branch
from
6f22b0a to
bfbf102
Compare
Contributor
Author
|
I have addressed all review comments. I will run a distcompare job over the weekend as there are one or two library changes which will affect other queries (mainly adding more testing frameworks). |
Contributor
Author
|
The distcompare job looks fine. No changes in what results we find. The timings are about the same - certainly within expected variation. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have based this on the java version (cf. github/codeql#3938).