Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests with docker #977

Closed
diraol opened this issue Dec 29, 2018 · 6 comments
Closed

Improve tests with docker #977

diraol opened this issue Dec 29, 2018 · 6 comments

Comments

@diraol
Copy link
Contributor

@diraol diraol commented Dec 29, 2018

Hi all!

We have been facing many issues related to vim/python versions.

I've been thinking that we need better way to test those combinations (vim + python) in a more "clean and isolated environment". Manually or not.

I thought about using docker to create such environments.

A possibility is to:

  • start a docker container
  • install the python version we want
  • build vim considering this specific python version
  • run the tests we want to run
  • enable the (python-mode) "developer" to go into the container and see if everything is OK.

I would like to have some feedback from the community regarding this topic and to see if there is anyone to help with it. I would love to do such improvements, but I cannot guarantee that I'll be able to do it in a reasonable time schedule.

@diraol diraol pinned this issue Dec 29, 2018
diraol added a commit to diraol/python-mode that referenced this issue Dec 30, 2018
Now we can propperly test python-mode in an environment with a very well
defined python version and a vim built/compiled for this specific
version as well.

The best way is to use the `build_docker_images.sh` file in order to
create the docker image with all python versions you desire.

Also, in order to run the container you just have to do:

docker run --rm -it python-mode:<version>

Related to python-mode#977
@diraol
Copy link
Contributor Author

@diraol diraol commented Dec 30, 2018

OK, I have an initial proposal....

diraol added a commit to diraol/python-mode that referenced this issue Jan 2, 2019
Now we can propperly test python-mode in an environment with a very well
defined python version and a vim built/compiled for this specific
version as well.

The best way is to use the `build_docker_images.sh` file in order to
create the docker image with all python versions you desire.

Also, in order to run the container you just have to do:

docker run --rm -it python-mode:<version>

Related to python-mode#977
diraol added a commit to diraol/python-mode that referenced this issue Jan 2, 2019
Now we can propperly test python-mode in an environment with a very well
defined python version and a vim built/compiled for this specific
version as well.

The best way is to use the `build_docker_images.sh` file in order to
create the docker image with all python versions you desire.

Also, in order to run the container you just have to do:

docker run --rm -it python-mode:<version>

Related to python-mode#977
diraol added a commit to diraol/python-mode that referenced this issue Jan 5, 2019
Now we can propperly test python-mode in an environment with a very well
defined python version and a vim built/compiled for this specific
version as well.

The best way is to use the `build_docker_images.sh` file in order to
create the docker image with all python versions you desire.

Also, in order to run the container you just have to do:

docker run --rm -it python-mode:<version>

Related to python-mode#977
diraol added a commit to diraol/python-mode that referenced this issue Jan 6, 2019
Now we can propperly test python-mode in an environment with a very well
defined python version and a vim built/compiled for this specific
version as well.

The best way is to use the `build_docker_images.sh` file in order to
create the docker image with all python versions you desire.

Also, in order to run the container you just have to do:

docker run --rm -it python-mode:<version>

Related to python-mode#977
diraol added a commit to diraol/python-mode that referenced this issue Jan 6, 2019
Now we can propperly test python-mode in an environment with a very well
defined python version and a vim built/compiled for this specific
version as well.

The best way is to use the `build_docker_images.sh` file in order to
create the docker image with all python versions you desire.

Also, in order to run the container you just have to do:

docker run --rm -it python-mode:<version>

Related to python-mode#977
diraol added a commit to diraol/python-mode that referenced this issue Jan 11, 2019
Now we can propperly test python-mode in an environment with a very well
defined python version and a vim built/compiled for this specific
version as well.

The best way is to use the `build_docker_images.sh` file in order to
create the docker image with all python versions you desire.

Also, in order to run the container you just have to do:

docker run --rm -it python-mode:<version>

Related to python-mode#977
diraol added a commit to diraol/python-mode that referenced this issue Jan 11, 2019
Now we can propperly test python-mode in an environment with a very well
defined python version and a vim built/compiled for this specific
version as well.

The best way is to use the `build_docker_images.sh` file in order to
create the docker image with all python versions you desire.

Also, in order to run the container you just have to do:

docker run --rm -it python-mode:<version>

Related to python-mode#977
diraol added a commit to diraol/python-mode that referenced this issue Jan 25, 2019
Now we can propperly test python-mode in an environment with a very well
defined python version and a vim built/compiled for this specific
version as well.

The best way is to use the `build_docker_images.sh` file in order to
create the docker image with all python versions you desire.

Also, in order to run the container you just have to do:

docker run --rm -it python-mode:<version>

Related to python-mode#977
diraol added a commit to diraol/python-mode that referenced this issue Feb 26, 2019
Now we can propperly test python-mode in an environment with a very well
defined python version and a vim built/compiled for this specific
version as well.

The best way is to use the `build_docker_images.sh` file in order to
create the docker image with all python versions you desire.

Also, in order to run the container you just have to do:

docker run --rm -it python-mode:<version>

Related to python-mode#977
diraol added a commit to diraol/python-mode that referenced this issue May 11, 2019
Now we can propperly test python-mode in an environment with a very well
defined python version and a vim built/compiled for this specific
version as well.

The best way is to use the `build_docker_images.sh` file in order to
create the docker image with all python versions you desire.

Also, in order to run the container you just have to do:

docker run --rm -it python-mode:<version>

Related to python-mode#977
diraol added a commit to diraol/python-mode that referenced this issue May 11, 2019
Now we can propperly test python-mode in an environment with a very well
defined python version and a vim built/compiled for this specific
version as well.

The best way is to use the `build_docker_images.sh` file in order to
create the docker image with all python versions you desire.

Also, in order to run the container you just have to do:

docker run --rm -it python-mode:<version>

Related to python-mode#977
diraol added a commit to diraol/python-mode that referenced this issue May 12, 2019
Now we can propperly test python-mode in an environment with a very well
defined python version and a vim built/compiled for this specific
version as well.

The best way is to use the `build_docker_images.sh` file in order to
create the docker image with all python versions you desire.

Also, in order to run the container you just have to do:

docker run --rm -it python-mode:<version>

Related to python-mode#977
@cdleong
Copy link

@cdleong cdleong commented May 23, 2019

I have some CI/Docker experience. Anything in particular you need help with here?

@jajajasalu2
Copy link

@jajajasalu2 jajajasalu2 commented Sep 18, 2019

I won't mind helping. What's the status on this?

@stale
Copy link

@stale stale bot commented Feb 15, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the inactive label Feb 15, 2020
@diraol diraol removed the inactive label Feb 15, 2020
diraol added a commit that referenced this issue Apr 21, 2020
Now we can propperly test python-mode in an environment with a very well
defined python version and a vim built/compiled for this specific
version as well.

The best way is to use the `build_docker_images.sh` file in order to
create the docker image with all python versions you desire.

Also, in order to run the container you just have to do:

docker run --rm -it python-mode:<version>

Related to #977
diraol added a commit to diraol/python-mode that referenced this issue Apr 21, 2020
Now we can propperly test python-mode in an environment with a very well
defined python version and a vim built/compiled for this specific
version as well.

The best way is to use the `build_docker_images.sh` file in order to
create the docker image with all python versions you desire.

Also, in order to run the container you just have to do:

docker run --rm -it python-mode:<version>

Related to python-mode#977
diraol added a commit to diraol/python-mode that referenced this issue Apr 21, 2020
Now we can propperly test python-mode in an environment with a very well
defined python version and a vim built/compiled for this specific
version as well.

The best way is to use the `build_docker_images.sh` file in order to
create the docker image with all python versions you desire.

Also, in order to run the container you just have to do:

docker run --rm -it python-mode:<version>

Related to python-mode#977
@stale
Copy link

@stale stale bot commented Jul 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the inactive label Jul 18, 2020
@stale
Copy link

@stale stale bot commented Aug 8, 2020

Closed due to inactivity.

@stale stale bot closed this Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.