Skip to content

bpo-42308: Add threading.__excepthook__#23218

Merged
vstinner merged 4 commits into
python:masterfrom
mariocj89:pu/excephook
Nov 12, 2020
Merged

bpo-42308: Add threading.__excepthook__#23218
vstinner merged 4 commits into
python:masterfrom
mariocj89:pu/excephook

Conversation

@mariocj89
Copy link
Copy Markdown
Contributor

@mariocj89 mariocj89 commented Nov 10, 2020

Add the new attribute to retrieve the original value of excephook in
case a broken or different value is set.

https://bugs.python.org/issue42308

Add the new attribute to retrieve the original value of excephook in
case a broken or different value is set.
Comment thread Lib/threading.py
Comment thread Doc/library/threading.rst Outdated
mariocj89 and others added 2 commits November 10, 2020 14:52
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Victor Stinner <vstinner@python.org>
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would appreciate a second review of another core review, to make sure that the feature is really useful.

Copy link
Copy Markdown
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogsal
Copy link
Copy Markdown
Member

@mariocj89 Can you add a What's new entry?

@mariocj89
Copy link
Copy Markdown
Contributor Author

Sure thing, added in 739f8d1

@vstinner vstinner merged commit 750c5ab into python:master Nov 12, 2020
@vstinner
Copy link
Copy Markdown
Member

Merged, thank you @mariocj89.

@mariocj89 mariocj89 deleted the pu/excephook branch November 12, 2020 17:34
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Add threading.__excepthook__ to allow retrieving the original value
of threading.excepthook in case it is set to a broken or a different
value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants