feat(toast): add 'swipeGesture' property to dismiss toasts via swipe#22133
Closed
TakumaKira wants to merge 132 commits intoionic-team:masterfrom
Closed
feat(toast): add 'swipeGesture' property to dismiss toasts via swipe#22133TakumaKira wants to merge 132 commits intoionic-team:masterfrom
TakumaKira wants to merge 132 commits intoionic-team:masterfrom
Conversation
…nent classes (ionic-team#22096) resolves ionic-team#22051
…onic-team#22101) * add additional history types * fix imports
… inside of the tabs outlet (ionic-team#22112) resolves ionic-team#22066
Improve Angular example by adding missing (`any`) typehint of the event
Release Ionic Vue 0.5.0
…-aria (ionic-team#22113) This also fixes the Select "popover" interface as it is made up of radio buttons WAI-ARIA Guidelines: - Tab and Shift + Tab: Move focus into and out of the radio group. When focus moves into a radio group : - If a radio button is checked, focus is set on the checked button. - If none of the radio buttons are checked, focus is set on the first radio button in the group. - Space: checks the focused radio button if it is not already checked. - Right Arrow and Down Arrow: move focus to the next radio button in the group, uncheck the previously focused button, and check the newly focused button. If focus is on the last button, focus moves to the first button. - Left Arrow and Up Arrow: move focus to the previous radio button in the group, uncheck the previously focused button, and check the newly focused button. If focus is on the first button, focus moves to the last button. Closes ionic-team#21743
…team#22352) This stops screen readers, such as NVDA, from reading every item as clickable even when it is text only. fixes ionic-team#22011
…side of a nav guard (ionic-team#22429) resolves ionic-team#22412
Contributor
|
why didn't u add the directions for swiping up (on top placed toasts) and swiping down (on bottom placed toasts)? |
This reverts commit 68afc49.
Co-authored-by: svennergr < svennergr@users.noreply.github.com>
Release 5.4.2
Contributor
Author
I just thought it was enough with horizontal swipes, but if you say so, anyone would need them. I will add them soon, thanks! |
Release 5.4.3
Contributor
|
@liamdebeasi @TakumaKira Is there no progress? |
13 tasks
Contributor
|
Hi everyone, I am going to close this in favor of #23124 as this PR is a bit outdated. If we merge the PR we will be sure to give credit to both @evgeniy-skakun and @TakumaKira. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #21769
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #21769
What is the new behavior?
swipeGestureproperty toleftorright, developers can allow dismissing the Toast via swiping.Does this introduce a breaking change?
Other information