Skip to content

/ node Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib,tools: enforce access to prototype from primordials #36025

Merged
merged 1 commit into from Nov 14, 2020
Merged

lib,tools: enforce access to prototype from primordials #36025

merged 1 commit into from Nov 14, 2020

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 7, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@aduh95 aduh95 requested a review from Leko Nov 7, 2020
@nodejs-github-bot

This comment has been hidden.

Sign in to view
@aduh95 aduh95 mentioned this pull request Nov 7, 2020
Merged
3 tasks
@aduh95 aduh95 mentioned this pull request Nov 8, 2020
Closed
2 tasks
Leko
Leko approved these changes Nov 8, 2020
View changes
@aduh95 aduh95 force-pushed the prototype-primordials branch from 0c56e81 to 6d364f8 Nov 9, 2020
@nodejs-github-bot

This comment has been hidden.

Sign in to view
@nodejs-github-bot

This comment has been hidden.

Sign in to view
@nodejs-github-bot

This comment has been hidden.

Sign in to view
@aduh95 aduh95 force-pushed the prototype-primordials branch from 249ca96 to 07bab9c Nov 10, 2020
@nodejs-github-bot

This comment has been hidden.

Sign in to view
@nodejs-github-bot

This comment has been hidden.

Sign in to view
@nodejs-github-bot

This comment has been hidden.

Sign in to view
@nodejs-github-bot

This comment has been hidden.

Sign in to view
@nodejs-github-bot

This comment has been hidden.

Sign in to view
Trott
Trott approved these changes Nov 11, 2020
View changes
@Trott Trott requested a review from guybedford Nov 11, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Nov 11, 2020 •
edited by aduh95

CI: https://ci.nodejs.org/job/node-test-pull-request/34336/ ✅

@aduh95 @Trott
lib,tools: enforce access to prototype from primordials
5c3944f 
PR-URL: nodejs#36025
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott Trott force-pushed the prototype-primordials branch from 26c722d to 5c3944f Nov 14, 2020
@Trott
Copy link
Member

@Trott Trott commented Nov 14, 2020

Landed in 5c3944f

@Trott Trott merged commit 5c3944f into nodejs:master Nov 14, 2020
29 of 30 checks passed
@aduh95 aduh95 deleted the prototype-primordials branch Nov 14, 2020
codebytere added a commit that referenced this issue Nov 22, 2020
@aduh95 @codebytere
lib,tools: enforce access to prototype from primordials
75707f4 
PR-URL: #36025
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Nov 22, 2020
Merged
targos added a commit that referenced this issue May 16, 2021
@aduh95 @targos
lib,tools: enforce access to prototype from primordials
483c1a1 
PR-URL: #36025
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos added a commit that referenced this issue Jun 11, 2021
@aduh95 @targos
lib,tools: enforce access to prototype from primordials
b3e22e1 
PR-URL: #36025
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott

@Leko Leko

@guybedford guybedford

Assignees
No one assigned
Labels
author ready process tools
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@aduh95 @nodejs-github-bot @Trott @Leko