Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: enforce use of single quotes in editorconfig #36020

Closed
wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 7, 2020

This is to avoid text editor to replace quotes by double quotes.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@aduh95 aduh95 added the request-ci label Nov 7, 2020
@nodejs-github-bot nodejs-github-bot added the tools label Nov 7, 2020
@github-actions github-actions bot removed the request-ci label Nov 7, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Nov 7, 2020

Trott
Trott approved these changes Nov 7, 2020
@aduh95 aduh95 added the author ready label Nov 7, 2020
lpinca
lpinca approved these changes Nov 12, 2020
@lpinca lpinca added the commit-queue label Nov 12, 2020
@github-actions github-actions bot removed the commit-queue label Nov 12, 2020
@github-actions
Copy link

@github-actions github-actions bot commented Nov 12, 2020

Landed in f6ada62...ba73f93

@github-actions github-actions bot closed this Nov 12, 2020
nodejs-github-bot added a commit that referenced this issue Nov 12, 2020
PR-URL: #36020
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95 aduh95 deleted the single-quotes branch Nov 12, 2020
codebytere added a commit that referenced this issue Nov 22, 2020
PR-URL: #36020
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Nov 22, 2020
BethGriggs added a commit that referenced this issue Dec 9, 2020
PR-URL: #36020
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs added a commit that referenced this issue Dec 10, 2020
PR-URL: #36020
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
BethGriggs added a commit that referenced this issue Dec 15, 2020
PR-URL: #36020
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready tools
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants