Skip to content

/ asyncpg

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null/NULL quoting in array text encoder #627

Merged
merged 1 commit into from Sep 25, 2020
Merged

Fix null/NULL quoting in array text encoder #627

merged 1 commit into from Sep 25, 2020

Conversation

@fantix
Copy link
Member

@fantix fantix commented Sep 25, 2020

When given a textual json codec that yields 'null', the array encoder should generate b'["null"]' instead of b'["NULL"]' for a JSON[] type.

Refs: #623
@fantix
Fix null/NULL quoting in array text encoder
Verified
This commit was signed with a verified signature.
fantix Fantix King
GPG key ID: 95304B04071CCDB4 Learn about signing commits
Loading status checks…
00e083a 
When given a textual json codec that yields 'null', the array
encoder should generate b'["null"]' instead of b'["NULL"]'
for a JSON[] type.

Refs: #623
@fantix fantix mentioned this pull request Sep 25, 2020
Closed
@fantix fantix marked this pull request as ready for review Sep 25, 2020
@elprans
elprans approved these changes Sep 25, 2020
View changes
Copy link
Member

@elprans elprans left a comment

Thanks!
@elprans elprans merged commit 92aa806 into MagicStack:master Sep 25, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fantix fantix deleted the fantix:t623-json-array-text-codec branch Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elprans elprans

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@fantix @elprans
You can’t perform that action at this time.