Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update Bazel to use fine-grained deps #1083

Merged
merged 1 commit into from Dec 23, 2018
Merged

build: update Bazel to use fine-grained deps #1083

merged 1 commit into from Dec 23, 2018

Conversation

@CaerusKaru
Copy link
Member

@CaerusKaru CaerusKaru commented Oct 13, 2018

No description provided.

@CaerusKaru CaerusKaru added this to the 6.0 milestone Oct 13, 2018
@CaerusKaru CaerusKaru added this to To do in Infrastructure via automation Oct 13, 2018
@googlebot googlebot added the cla: yes label Oct 13, 2018
@CaerusKaru CaerusKaru force-pushed the adam/bazel branch 4 times, most recently from ee78033 to 08aa3d7 Oct 13, 2018
@CaerusKaru
Copy link
Member Author

@CaerusKaru CaerusKaru commented Oct 13, 2018

Before I forget, credit for a lot of this goes to @devversion's incredible work over on Material.

@CaerusKaru
Copy link
Member Author

@CaerusKaru CaerusKaru commented Oct 13, 2018

This is blocked on the test step because socket-engine, hapi-engine, and express-engine tests bring in platform-server, which doesn't wire up correctly with domino and xhr2.

@CaerusKaru CaerusKaru force-pushed the adam/bazel branch 16 times, most recently from b6f595e to e8be23a Dec 21, 2018
@CaerusKaru CaerusKaru force-pushed the adam/bazel branch from e8be23a to d858966 Dec 23, 2018
@CaerusKaru CaerusKaru changed the title WIP: build: update Bazel to use fine-grained deps build: update Bazel to use fine-grained deps Dec 23, 2018
"@angular/animations": "file:../../node_modules/@angular/animations",
"@angular/common": "file:../../node_modules/@angular/common",
"@angular/animations": "^7.1.4",
"@angular/common": "^7.1.4",
"@angular/compiler": "file:../../node_modules/@angular/compiler",

This comment has been minimized.

@Toxicable

Toxicable Dec 23, 2018
Contributor

why are some of these files some version?

This comment has been minimized.

@CaerusKaru

CaerusKaru Dec 23, 2018
Author Member

They're no longer installed at the top-level because Angular is now built from source with Bazel

This comment has been minimized.

@Toxicable

Toxicable Dec 23, 2018
Contributor

but there's still a few that are manually installed?

This comment has been minimized.

@CaerusKaru

CaerusKaru Dec 23, 2018
Author Member

Yeah there's a reason, but I can't remember what it was. This makes it clear though that these deps are only needed for integration testing.

@CaerusKaru CaerusKaru merged commit 9b83bbe into master Dec 23, 2018
6 checks passed
6 checks passed
ci/circleci: bazel-lint Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-packages-dist Your tests passed on CircleCI!
Details
ci/circleci: integration_test Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
Infrastructure automation moved this from To do to Done Dec 23, 2018
@CaerusKaru CaerusKaru deleted the adam/bazel branch Dec 23, 2018
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Sep 6, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants