Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove pythonDot highlight match #927
Conversation
This confuses the 'cursorline' and 'cursorcolumn' vim options
until python-mode/python-mode#927 is merged or addressed.
|
@zhimsel sorry not giving a feedback before. I've tested over here in a clean environment, and I was not able to reproduce the behavior you described. I mean, I've tested with only Are you sure that there isn't any other plugins/configs interacting in your environment? Which theme are you using? solarized-dark? |
It's quite possible. I can do some reductive testing to see if any other plugins are interfering when I get the time. I'll report back here once I've had the chance.
Yes, solarized-dark. |
|
@diraol I was able to do some more verification of this issue. Using the following vimrc with neovim source ~/.vim/vim-plug/plug.vim " managed externally
call plug#begin('~/.vim/plugins')
Plug 'altercation/vim-colors-solarized'
Plug '~/dev/python-mode',
call plug#end()
" Set color scheme
silent! colorscheme solarized
set cursorline " Highlight current line
syntax enable " Enable syntax highlighting
" show highlight group for what's under the cursor
map <F10> :echo "hi<" . synIDattr(synID(line("."),col("."),1),"name") . '> trans<'
\ . synIDattr(synID(line("."),col("."),0),"name") . "> lo<"
\ . synIDattr(synIDtrans(synID(line("."),col("."),1)),"name") . ">"<CR>I confirmed that the The main reason for this PR was not for a specific issue (my highlighting issue was just a symptom). I submitted this PR because I noticed that the |
|
Hum... got it! Well, I could not reproduce it, not even with your suggestion under a clean env (dockerized). But the proposed changes seems to be reasonable after all (now that you explained the reason behind it). |
|
No problem! Thanks for merging! |
Now that python-mode/python-mode#927 has been merged into 'develop'.
When the
cursorcolumnorcursorlinevim option is set, any.characters result in the highlighting being set toNormal(instead of blank). This means that the "highlighted" line (viacursorline) is broken over the period. Please see attached screenshot for an example:As far as I can tell, the
pythonDotmatch doesn't really do anything except drop the highlighting back toNormalin apythonDottedNamematch. This just seems useless, so I think we should just remove it and let the dots have the same highlight as the rest of thepythonDottedNamematches.The main reason for this PR was not for a specific issue (my highlighting issue was just a symptom). I submitted this PR because I noticed that the
pythonDothighlight group seemed entirely pointless. All it does is drop the highlighting for any.characters toNormal. This doesn't seem to be expected or desired behavior (the.should match the surrounding highlight).