fix(material/menu): unable to move focus from inside opened event #20968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
crisbeto
added
the
merge ready
We move focus inside the menu after we've dispatched the `menuOpened` event which means that we'll override any focus that the consumer may have set inside the handler. These changes fix the issue by changing the order. Fixes angular#20965.
crisbeto
force-pushed
the
20965/menu-opened-focus
branch
from
31a0289
to
010753d
Compare
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this issue
Feb 8, 2021
…gular#20968) We move focus inside the menu after we've dispatched the `menuOpened` event which means that we'll override any focus that the consumer may have set inside the handler. These changes fix the issue by changing the order. Fixes angular#20965.
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this issue
Feb 8, 2021
…gular#20968) We move focus inside the menu after we've dispatched the `menuOpened` event which means that we'll override any focus that the consumer may have set inside the handler. These changes fix the issue by changing the order. Fixes angular#20965.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
We move focus inside the menu after we've dispatched the
menuOpenedevent which means that we'll override any focus that the consumer may have set inside the handler. These changes fix the issue by changing the order.Fixes #20965.