Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWIP: migrate to asyncio and httpx #998
Open
Conversation
convert more functions to async and add a async_ prefix for them add sync functions for the async ones
fix typo in v4/objects.py add a async __setup__ to call after init is run
|
at the moment the httpx module dose not support |
|
Thanks for all the efforts on this. Maybe we should wait until the 1.0 release of https in April?
|
|
yeah probably hopefully they fix the two issues that are blocking this pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
starting to migrate to async while staying compatible to the syncronous versions.
TODO:
which funktions are suposed to be called by the user? if possible i would like to keep all internal funktions async and run the functions that have to be sync with
run_until_complete()would it be better to have a centrel event_loop instead of getting it with
get_event_loopevery time and if so where would i put it?fix #945