Hi @ludwig-weiss. Thanks for your MR! Would you mind to add a couple of tests and some docs?

Hi @ludwig-weiss. Thanks for your MR! Would you mind to add a couple of tests and some docs?

Not at all, but I was unsure what and how to test. Could you point me to an example?

I guess the tests are going through a little transition phase right now, regarding their structure. Sorry! But you can just add tests similar to this: https://github.com/python-gitlab/python-gitlab/blob/master/gitlab/tests/objects/test_projects.py. Thanks 👍

I am not a python/python tests pro. The example seems too broad to me.

Is there a test for e.g ProjectPipelineJobManager https://github.com/python-gitlab/python-gitlab/blob/master/gitlab/v4/objects.py#L3651

This seems similar to the classes I added.
A manager with only ListMixin and RestManager added.

When I try to figure what to test for this GET only API I come to this:

• mock one or more results of this api
• call the code
• compare the result with the mock

For this simple GET API I am under the impression that we would test the mock only.
Am I wrong here?

Yes it does test the mock only, but the functional tests alone are kind of unreliable.