Created on 2020-06-12 10:05 by erlendaasland, last changed 2020-10-13 18:16 by erlendaasland.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 20826 | closed | erlendaasland, 2020-06-12 10:10 | |
| PR 22484 | open | erlendaasland, 2020-10-01 19:37 | |
| PR 22478 | erlendaasland, 2020-10-13 09:11 | ||
| Messages (6) | |||
|---|---|---|---|
| msg371347 - (view) | Author: Erlend Egeberg Aasland (erlendaasland) * | Date: 2020-06-12 10:05 | |
Use Argument Clinic in sqlite3. |
|||
| msg378558 - (view) | Author: Dong-hee Na (corona10) *  |
Date: 2020-10-13 14:00 | |
What's the purpose of using AC, did the change improve performance? It can make hard to track the code history. |
|||
| msg378560 - (view) | Author: Erlend Egeberg Aasland (erlendaasland) * | Date: 2020-10-13 14:38 | |
The primary reason is that it will be provide easy access to module state. The first step in making sqlite3 support multiphase init was to create heap types. The second step is argument clinic. The third will be to use AC for module state. The last step will then be final multiphase support. Also, IMHO, AC greatly improves the body of methods (readability => maintainability, hardened parsing of arguments) |
|||
| msg378561 - (view) | Author: Erlend Egeberg Aasland (erlendaasland) * | Date: 2020-10-13 14:47 | |
Also, see the comment from Victor here: https://github.com/python/cpython/pull/22478#issuecomment-702201260 |
|||
| msg378562 - (view) | Author: Dong-hee Na (corona10) * |
Date: 2020-10-13 15:02 | |
> Also, see the comment from Victor here: https://github.com/python/cpython/pull/22478#issuecomment-702201260 Okay got it |
|||
| msg378571 - (view) | Author: Erlend Egeberg Aasland (erlendaasland) * | Date: 2020-10-13 18:16 | |
By the way, what's the preferred way to benchmark performance? |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2020-10-13 18:16:14 | erlendaasland | set | messages: + msg378571 |
| 2020-10-13 15:02:08 | corona10 | set | messages: + msg378562 |
| 2020-10-13 14:47:46 | erlendaasland | set | messages: + msg378561 |
| 2020-10-13 14:38:04 | erlendaasland | set | messages: + msg378560 |
| 2020-10-13 14:00:56 | corona10 | set | nosy:
+ corona10 messages: + msg378558 |
| 2020-10-13 09:13:28 | erlendaasland | set | nosy:
+ vstinner, berker.peksag |
| 2020-10-13 09:11:58 | erlendaasland | set | pull_requests: + pull_request21654 |
| 2020-10-01 19:37:51 | erlendaasland | set | pull_requests: + pull_request21501 |
| 2020-06-12 10:10:15 | erlendaasland | set | keywords:
+ patch stage: patch review pull_requests: + pull_request20021 |
| 2020-06-12 10:05:35 | erlendaasland | create | |