Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-37483: Add PyObject_CallOneArg() in the What's New in Python 3.9 #23062

Merged
merged 1 commit into from Nov 1, 2020
Merged

bpo-37483: Add PyObject_CallOneArg() in the What's New in Python 3.9 #23062

merged 1 commit into from Nov 1, 2020

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Oct 31, 2020 •
edited by bedevere-bot

@corona10 corona10 requested a review from vstinner Oct 31, 2020
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Oct 31, 2020
@corona10 corona10 requested review from methane and jdemeyer Oct 31, 2020
vstinner
vstinner requested changes Oct 31, 2020
View changes
Copy link
Member

@vstinner vstinner left a comment

Private function should not be documented. Only public function should be documented.

@bedevere-bot
Copy link

bedevere-bot commented Oct 31, 2020

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

vstinner
vstinner reviewed Oct 31, 2020
View changes
Doc/whatsnew/3.9.rst Outdated Show resolved Hide resolved
@vstinner
Copy link
Member

vstinner commented Oct 31, 2020 •
edited by bedevere-bot

PR title:

bpo-37483: Add missing API in the What's New in Python 3.9 #23062

I suggest:

bpo-37483: Add PyObject_CallOneArg() in the What's New in Python 3.9

@corona10 corona10 changed the title bpo-37483: Add missing API in the What's New in Python 3.9 bpo-37483: Add PyObject_CallOneArg() in the What's New in Python 3.9 Nov 1, 2020
@corona10 corona10 requested a review from vstinner Nov 1, 2020
@corona10
Copy link
Member Author

corona10 commented Nov 1, 2020

I have made the requested changes; please review again

@bedevere-bot
Copy link

bedevere-bot commented Nov 1, 2020

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

vstinner
vstinner approved these changes Nov 1, 2020
View changes
Copy link
Member

@vstinner vstinner left a comment

LGTM.

@corona10 corona10 merged commit 7feb54a into python:master Nov 1, 2020
3 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Nov 1, 2020

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 1, 2020
@corona10 @miss-islington
bpo-37483: Add PyObject_CallOneArg() in the What's New in Python 3.9 (p…
a762911 
…ythonGH-23062)

(cherry picked from commit 7feb54a)

Co-authored-by: Dong-hee Na <donghee.na@python.org>
@bedevere-bot
Copy link

bedevere-bot commented Nov 1, 2020

GH-23074 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Nov 1, 2020
@miss-islington @corona10
bpo-37483: Add PyObject_CallOneArg() in the What's New in Python 3.9 (G…
0312efc 
…H-23062)

(cherry picked from commit 7feb54a)

Co-authored-by: Dong-hee Na <donghee.na@python.org>
@corona10 corona10 deleted the bpo-37483-news branch Nov 1, 2020
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@corona10 @adorilson
bpo-37483: Add PyObject_CallOneArg() in the What's New in Python 3.9 (p…
918485f 
…ythonGH-23062)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

@methane methane

@jdemeyer jdemeyer

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@corona10 @bedevere-bot @vstinner @miss-islington @the-knights-who-say-ni