Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step for fetching backers.json to website install steps #10631

Merged
merged 2 commits into from Oct 13, 2020
Merged

Add step for fetching backers.json to website install steps #10631

merged 2 commits into from Oct 13, 2020

Conversation

stdavis
Copy link
Contributor

@stdavis stdavis commented Oct 13, 2020

Supercedes: #10191
Fixes: #9808

Summary

When attempting to run yarn start for the first time after following the install steps I got this error message:

Error: Cannot find module '/Users/stdavis/Documents/Projects/jest/website/backers.json'

This PR adds the required command to fix this error.

Test plan

I've run node fetchSupporters.js and now the website behaves normally without errors.

@stdavis stdavis changed the title docs(website): add step for fetching backers.json Add step for fetching backers.json to website install steps Oct 13, 2020
@stdavis stdavis marked this pull request as ready for review Oct 13, 2020
SimenB
SimenB approved these changes Oct 13, 2020
Copy link
Collaborator

@SimenB SimenB left a comment

I agree documenting is better than trying scripting it at this point. Thanks!

@SimenB SimenB merged commit e617969 into facebook:master Oct 13, 2020
18 of 21 checks passed
@stdavis stdavis deleted the fetch-supporters-docs branch Oct 13, 2020
@D0rmouse
Copy link

@D0rmouse D0rmouse commented Oct 13, 2020

How does this fix #9808? Typo?

@jeysal
Copy link
Collaborator

@jeysal jeysal commented Oct 13, 2020

Yep, fixing

@github-actions
Copy link

@github-actions github-actions bot commented May 11, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants