PyFuncArgs from rust tuple#2250
Merged
Merged
Conversation
youknowone
force-pushed
the
funcargs
branch
2 times, most recently
from
6e1c712 to
5d6ea02
Compare
coolreader18
reviewed
Oct 1, 2020
which does not represent a single python object
Member
Author
|
@coolreader18 will you also review this again? |
coolreader18
approved these changes
Oct 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now what we have:
FuncArgs::newto replaceFrom((Args, KwArgs))vm.invoke(callable, (tuple,))Now what we don't have:
From((Args, KwArgs))From((&Args, &KwArgs))From(PyRef)- this is simply replaced by single argument tuple.