Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add errors one sentence. #45

Closed
wants to merge 4 commits into from
Closed

Add errors one sentence. #45

wants to merge 4 commits into from

Conversation

@AlexWUrobot
Copy link

@AlexWUrobot AlexWUrobot commented Oct 13, 2018

No description provided.

Copy link
Collaborator

@adrianliaw adrianliaw left a comment

Thank you for contributing! I have some comments in the review, could you read it, please?

@@ -29,6 +30,8 @@ msgid ""
"tried out the examples you have probably seen some. There are (at least) "
"two distinguishable kinds of errors: *syntax errors* and *exceptions*."
msgstr ""
"到目前為止錯誤訊息還沒有提到,但如果你嘗試這些範例,你可能會發現一些問題。有"

This comment has been minimized.

@adrianliaw

adrianliaw Oct 14, 2018
Collaborator

The first sentence should keep the SVO order in Chinese grammar, "錯誤訊息" and "還沒有提到" should be swapped.

Also, what do you mean by the word "問題"?

This comment has been minimized.

@AlexWUrobot

AlexWUrobot Oct 16, 2018
Author

I fix it

@@ -29,6 +30,8 @@ msgid ""
"tried out the examples you have probably seen some. There are (at least) "
"two distinguishable kinds of errors: *syntax errors* and *exceptions*."
msgstr ""
"到目前為止錯誤訊息還沒有提到,但如果你嘗試這些範例,你可能會發現一些問題。有"
"(至少)兩種明顯的錯誤分別是*語法錯誤*和*例外*。"

This comment has been minimized.

@adrianliaw

adrianliaw Oct 14, 2018
Collaborator

The parentheses here should be full-width. The stars for marking the italic texts should have "un-spaced separator" put before them, as described in the translation guide.

Also, the word "分別" could be ambiguous, it could mean both "distinguishing" or "namely blah and blah", I think it would be better if some proper punctuation is attached to make the meaning unambiguous.

This comment has been minimized.

@AlexWUrobot

AlexWUrobot Oct 16, 2018
Author

I fix it
Thank you very much
this is my first to use it.

@AlexWUrobot AlexWUrobot changed the title Add errors one sentence. Add errors one sentence v2 fix it Oct 16, 2018
@AlexWUrobot AlexWUrobot changed the title Add errors one sentence v2 fix it Add errors one sentence. Oct 16, 2018
@adrianliaw adrianliaw closed this Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.