classification
Title: bytecode_helper assertNotInBytecode fails too eagerly
Type: Stage: patch review
Components: Tests Versions: Python 3.10, Python 3.9, Python 3.8, Python 3.7, Python 3.6
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: dino.viehland, tekknolagi
Priority: normal Keywords: patch

Created on 2020-10-29 21:22 by tekknolagi, last changed 2020-12-18 00:30 by dino.viehland.

Pull Requests
URL Status Linked Edit
PR 23031 merged tekknolagi, 2020-10-29 21:24
Messages (2)
msg379885 - (view) Author: Maxwell Bernstein (tekknolagi) * Date: 2020-10-29 21:22 
assertNotInBytecode should only fail if:

* the instr matches and the arg is unspecified, or
* the instr matches, the arg is specified, and the arg matches

But right now it fails in a third case because of the dangling self.fail() call. The self.fail() call should be moved into the `if`/`elif`.
msg383275 - (view) Author: Dino Viehland (dino.viehland) * (Python committer) Date: 2020-12-18 00:30 
New changeset 6e799be0a18d0bb5bbbdc77cd3c30a229d31dfb4 by Max Bernstein in branch 'master':
bpo-42199: Fix bytecode_helper assertNotInBytecode (#23031)
https://github.com/python/cpython/commit/6e799be0a18d0bb5bbbdc77cd3c30a229d31dfb4
History
Date User Action Args
2020-12-18 00:30:39dino.viehlandsetnosy: + dino.viehland
messages: + msg383275
2020-10-29 21:24:14tekknolagisetkeywords: + patch
stage: patch review
pull_requests: + pull_request21950
2020-10-29 21:22:06tekknolagicreate