Skip to content

/ zio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Borrow back useful improvements to ZIO Tracing, if any, from cats-effect's implementation #3964

Open
neko-kai opened this issue Jul 12, 2020 · 3 comments
Open

Borrow back useful improvements to ZIO Tracing, if any, from cats-effect's implementation #3964

neko-kai opened this issue Jul 12, 2020 · 3 comments
Labels
cats effect good first issue rts zmx

Comments

@neko-kai
Copy link
Member

@neko-kai neko-kai commented Jul 12, 2020

CE have released their own take on tracing, with following notable changes compared to original ZIO Tracing:

  • Instead of parsing lambdas, CE throws exceptions in IO constructors and cleans up stacktraces. That also means there is no regional control of tracing and AFAIK no way to avoid slight overhead even when tracing is completely disabled – but OTOH it may probably work on Scala.js
  • Traces include names of the instructions - map, flatMap, etc. This can be useful. It may be easier to read 
    at future `map` (x.scala:123)
    Instead of the current 
    at future continuation (x.scala:123)
    I feel like adding this information to ZIO Traces may be a nice UX improvement.

release notes: https://github.com/typelevel/cats-effect/releases/tag/v2.2.0-RC1
PR: typelevel/cats-effect#854
@lemastero
Copy link
Contributor

@lemastero lemastero commented Jul 28, 2020

I can 👀 at changes and see if we improve tracing in zio, if that is OK.
@neko-kai
Copy link
Member Author

@neko-kai neko-kai commented Jul 28, 2020

@lemastero Definitely OK 👍
@lemastero
Copy link
Contributor

@lemastero lemastero commented Aug 7, 2020

I don't mind if sb will work on it in parallel. (CE internals are not easy to understand, I am experimenting with zio-zmx as it seems relevant in here).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cats effect good first issue rts zmx
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@neko-kai @lemastero
You can’t perform that action at this time.