Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events: add a few tests #35806

Closed
wants to merge 1 commit into from
Closed

events: add a few tests #35806

wants to merge 1 commit into from

Conversation

benjamingr
Copy link
Member

@benjamingr benjamingr commented Oct 26, 2020

Added a few EventTarget tests I've found by playing with the code and "porting" bits of the spec I've read.

Note that at the moment Chrome has different prototype keys for Event though I could not figure out if that bit is actually required by the spec.

Object.keys(Object.getPrototypeOf(new Event('foo'))); // different between chrome and Node
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@benjamingr benjamingr added the events label Oct 26, 2020
@benjamingr benjamingr requested a review from jasnell Oct 26, 2020
@nodejs-github-bot nodejs-github-bot added the test label Oct 26, 2020
@targos
Copy link
Member

@targos targos commented Oct 26, 2020 •
edited

Port a few tests from what (commit message)?

@benjamingr benjamingr changed the title events: port a few tests from events: add a few tests Oct 26, 2020
@benjamingr
Copy link
Member Author

@benjamingr benjamingr commented Oct 26, 2020

I initially wanted to port tests from chromium but couldn't find relevant ones - so I just went over the spec looking for bits we don't cover and added tests for them.

@codecov-io
Copy link

@codecov-io codecov-io commented Oct 26, 2020

Codecov Report

Merging #35806 into master will decrease coverage by 8.97%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #35806      +/-   ##
==========================================
- Coverage   96.87%   87.89%   -8.98%     
==========================================
  Files         212      477     +265     
  Lines       69486   113171   +43685     
  Branches        0    25427   +25427     
==========================================
+ Hits        67315    99475   +32160     
- Misses       2171     7994    +5823     
- Partials        0     5702    +5702
Impacted Files Coverage Δ
lib/internal/crypto/scrypt.js 28.33% <0.00%> (-71.67%) ⬇️
lib/internal/idna.js 55.55% <0.00%> (-11.12%) ⬇️
lib/internal/blocklist.js 88.70% <0.00%> (-10.49%) ⬇️
lib/internal/crypto/diffiehellman.js 89.36% <0.00%> (-9.61%) ⬇️
lib/internal/modules/esm/get_source.js 83.33% <0.00%> (-7.15%) ⬇️
lib/internal/modules/esm/get_format.js 86.11% <0.00%> (-6.95%) ⬇️
lib/internal/streams/legacy.js 93.85% <0.00%> (-6.15%) ⬇️
lib/internal/crypto/keys.js 93.32% <0.00%> (-5.89%) ⬇️
lib/internal/crypto/util.js 94.32% <0.00%> (-5.68%) ⬇️
lib/internal/histogram.js 79.78% <0.00%> (-5.32%) ⬇️
... and 405 more

@benjamingr benjamingr mentioned this pull request Oct 26, 2020
Closed
3 tasks
@benjamingr benjamingr added the author ready label Oct 28, 2020
@Trott Trott added the request-ci label Oct 28, 2020
@github-actions github-actions bot removed the request-ci label Oct 28, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
ExE-Boss
ExE-Boss reviewed Oct 28, 2020
View changes
lib/internal/event_target.js Outdated Show resolved Hide resolved
@benjamingr benjamingr added the request-ci label Oct 28, 2020
@github-actions github-actions bot removed the request-ci label Oct 28, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@benjamingr benjamingr added the request-ci label Oct 28, 2020
@github-actions github-actions bot removed the request-ci label Oct 28, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@benjamingr benjamingr added the request-ci label Oct 28, 2020
@github-actions github-actions bot removed the request-ci label Oct 28, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@benjamingr benjamingr added the request-ci label Oct 29, 2020
@github-actions github-actions bot removed the request-ci label Oct 29, 2020
@benjamingr
Copy link
Member Author

@benjamingr benjamingr commented Nov 3, 2020

Rebased

@benjamingr benjamingr added the request-ci label Nov 3, 2020
@aduh95 aduh95 added the author ready label Nov 3, 2020
@github-actions github-actions bot removed the request-ci label Nov 3, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Nov 3, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/34039/

@benjamingr benjamingr added the commit-queue label Nov 3, 2020
@github-actions github-actions bot added commit-queue-failed and removed commit-queue labels Nov 3, 2020
@github-actions
Copy link

@github-actions github-actions bot commented Nov 3, 2020

Commit Queue failed
- Loading data for nodejs/node/pull/35806
✔  Done loading data for nodejs/node/pull/35806
----------------------------------- PR info ------------------------------------
Title      events: add a few tests (#35806)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     benjamingr:event-target-tests -> nodejs:master
Labels     author ready, events, test
Commits    1
 - events: add a few tests
Committers 1
 - Benjamin Gruenbaum 
PR-URL: https://github.com/nodejs/node/pull/35806
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/35806
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - events: add a few tests
   ✔  Last GitHub Actions successful
   ℹ  Last Full PR CI on 2020-11-03T14:36:19Z: https://ci.nodejs.org/job/node-test-pull-request/34039/
- Querying data for job/node-test-pull-request/34039/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ℹ  This PR was created on Mon, 26 Oct 2020 09:13:53 GMT
   ✔  Approvals: 2
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35806#pullrequestreview-516666200
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/35806#pullrequestreview-516905787
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

Commit Queue action: https://github.com/nodejs/node/actions/runs/343910509

@benjamingr
Copy link
Member Author

@benjamingr benjamingr commented Nov 3, 2020 •
edited

@aduh95 can you LGTM after the rebase so I can land with the commit queue? (assuming you think the changes are LGTM)

aduh95
aduh95 approved these changes Nov 3, 2020
View changes
Copy link
Contributor

@aduh95 aduh95 left a comment

RSLGTM

@aduh95 aduh95 added commit-queue and removed commit-queue-failed labels Nov 3, 2020
@github-actions github-actions bot removed the commit-queue label Nov 3, 2020
@github-actions
Copy link

@github-actions github-actions bot commented Nov 3, 2020

Landed in 1bc1f84...ee749ba

@github-actions github-actions bot closed this Nov 3, 2020
nodejs-github-bot pushed a commit that referenced this issue Nov 3, 2020
@benjamingr @nodejs-github-bot
events: add a few tests
ee749ba 
PR-URL: #35806
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this issue Nov 4, 2020
@benjamingr @targos
events: add a few tests
1cdfaa8 
PR-URL: #35806
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Nov 4, 2020
Merged
@ExE-Boss ExE-Boss mentioned this pull request Feb 5, 2021
Merged
@targos targos added the backport-open-v14.x label Apr 24, 2021
targos pushed a commit to targos/node that referenced this issue Apr 24, 2021
@benjamingr @targos
events: add a few tests
e6443f2 
PR-URL: nodejs#35806
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Apr 24, 2021
Closed
targos pushed a commit to targos/node that referenced this issue Apr 26, 2021
@benjamingr @targos
events: add a few tests
6eff327 
PR-URL: nodejs#35806
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit to targos/node that referenced this issue Apr 30, 2021
@benjamingr @targos
events: add a few tests
01d2b67 
PR-URL: nodejs#35806
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this issue Apr 30, 2021
@benjamingr @targos
events: add a few tests
6558ffa 
PR-URL: #35806
Backport-PR-URL: #38386
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos added backported-to-v14.x and removed author ready backport-open-v14.x labels Apr 30, 2021
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ExE-Boss ExE-Boss

@jasnell jasnell

@Trott Trott

@aduh95 aduh95

Assignees
No one assigned
Labels
backported-to-v14.x events test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@benjamingr @targos @codecov-io @nodejs-github-bot @aduh95 @jasnell @Trott @ExE-Boss