Skip to content

/ feathers

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(authentication): Remove entity from connection information on logout #1889

Merged
merged 2 commits into from Mar 28, 2020
Merged

fix(authentication): Remove entity from connection information on logout #1889

merged 2 commits into from Mar 28, 2020

Conversation

@daffl
Copy link
Member

@daffl daffl commented Mar 24, 2020

This pull request makes sure that all connection information gets removed on logout.

Closes #1883
daffl added 2 commits Mar 24, 2020
@daffl
fix(authentication): Fully clear connection information on logout
Loading status checks…
ab0a53b
@daffl
Only delete entity and nothing else from the connection
Loading status checks…
058f35a
@daffl daffl mentioned this pull request Mar 26, 2020
Open
@daffl daffl changed the title fix(authentication): Fully clear connection information on logout fix(authentication): Remove entity from connection information on logout Mar 26, 2020
@daffl daffl mentioned this pull request Mar 26, 2020
Closed
@daffl daffl merged commit b062753 into master Mar 28, 2020
9 checks passed
9 checks passed
build (10.x)
Details
build (10.x)
Details
build (12.x)
Details
build (12.x)
Details
build (13.x)
Details
build (13.x)
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (50% threshold)
Details
codeclimate/total-coverage 97% (0.0% change)
Details
@daffl daffl deleted the remove-connection branch Mar 28, 2020
@snyk-bot snyk-bot mentioned this pull request May 1, 2020
Merged
@rnbrady rnbrady mentioned this pull request Jun 19, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

user entity is not getting removed on logout
1 participant
@daffl
You can’t perform that action at this time.