crypto: fixup scrypt regressions #35821
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a handful of regressions in scrypt support following the refactor. Fixes: nodejs#35815
|
Review requested: |
nodejs-github-bot
added
c++
jasnell
added
crypto
addaleax
approved these changes
Oct 26, 2020
github-actions
bot
removed
the
request-ci
jasnell
added
the
author ready
tniessen
approved these changes
Oct 26, 2020
github-actions
bot
removed
the
request-ci
Trott
approved these changes
Oct 27, 2020
aduh95
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 30e9fab...05bb1b3 |
tniessen
added a commit
to tniessen/node
that referenced
this issue
Nov 4, 2020
2 tasks
lpinca
added a commit
that referenced
this issue
Nov 5, 2020
PR-URL: #35972 Refs: #35821 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
added a commit
that referenced
this issue
Nov 9, 2020
PR-URL: #35972 Refs: #35821 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs
added
the
dont-land-on-v14.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes a handful of regressions in scrypt support following
the refactor.
Fixes: #35815
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes