Skip to content

/ pyperformance

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade bm_tornado_http to Tornado 6.0.3 #77

Merged
merged 1 commit into from Dec 17, 2019
Merged

Upgrade bm_tornado_http to Tornado 6.0.3 #77

merged 1 commit into from Dec 17, 2019
+3 −4

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Dec 17, 2019

No description provided.

@vstinner vstinner requested a review from methane Dec 17, 2019
@vstinner
Copy link
Member Author

@vstinner vstinner commented Dec 17, 2019

#76 becomes a blocker issue for Python 3.9, so I propose to upgrade to Tornado 6 and abandon Python 2.7 support.

I'm not sure about yield self.flush(), but I don't get any warning, so it might be ok :-)
@methane
methane approved these changes Dec 17, 2019
View changes
@vstinner
Upgrade bm_tornado_http to Tornado 6.0.3
Loading status checks…
93930cc
@vstinner vstinner force-pushed the tornado6 branch from 5afdbdf to 93930cc Dec 17, 2019
@vstinner
Copy link
Member Author

@vstinner vstinner commented Dec 17, 2019

I rebased the PR on top of #78 which dropped Python 2 support.
@vstinner vstinner merged commit 89656c4 into master Dec 17, 2019
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@vstinner vstinner deleted the tornado6 branch Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@vstinner @methane
You can’t perform that action at this time.