fix memory leak in the async_local_storage scope manager #1134

rochdev · 2020-10-23T15:52:12Z

What does this PR do?

Fix memory leak in the async_local_storage scope manager.

Motivation

There is a bug in AsyncLocalStorage where enterWith may be called while in the callback of exit, causing the storage instance to be re-added to the internal storage list. This slows down the application continuously until it's no longer able to respond to requests. A fix will need to be done in Node, but in the meantime we can simply remove our call to exit since it was just an optimization that is unnecessary.

Fixes #1133

rochdev · 2020-10-23T19:07:26Z

Fix in Node: nodejs/node#35779

fix memory leak in the async_local_storage scope manager

Verified

This commit was signed with a verified signature.

rochdev Roch Devost

GPG key ID: 355D4332C0990EFF Learn about signing commits

Loading status checks…

bf74688

rochdev added bug core labels Oct 23, 2020

rochdev added this to the 0.28.0 milestone Oct 23, 2020

rochdev requested a review from DataDog/apm-js as a code owner Oct 23, 2020

bengl approved these changes Oct 23, 2020

View changes

rochdev deleted the fix-async-local-storage-exit-leak branch Oct 23, 2020

DataDog / dd-trace-js

fix memory leak in the async_local_storage scope manager #1134

fix memory leak in the async_local_storage scope manager #1134

rochdev commented Oct 23, 2020

rochdev commented Oct 23, 2020

DataDog / dd-trace-js

fix memory leak in the async_local_storage scope manager #1134

fix memory leak in the async_local_storage scope manager #1134

Conversation

rochdev commented Oct 23, 2020

What does this PR do?

Motivation

rochdev commented Oct 23, 2020