Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate test/node-api/test_worker_terminate_finalization/test.js #35778

Open
mhdawson opened this issue Oct 23, 2020 · 1 comment
Open

Investigate test/node-api/test_worker_terminate_finalization/test.js #35778

mhdawson opened this issue Oct 23, 2020 · 1 comment
Labels
n-api

Comments

@mhdawson
Copy link
Member

@mhdawson mhdawson commented Oct 23, 2020

  • Version: 12.x and higher
  • Platform: ALL
  • Subsystem: N-API

Refs: #35777

What steps will reproduce the bug?

Run test test/node-api/test_worker_terminate_finalization/test.js under ASAN/memory check

How often does it reproduce? Is there a required condition?

What is the expected behavior?

No memory leaks reported

What do you see instead?

Memory leaks reported

Additional information

We need to investigate the test to see if it is an issue in the test or in N-API itself.
@mhdawson mhdawson added the n-api label Oct 23, 2020
@mhdawson
Copy link
Member Author

@mhdawson mhdawson commented Oct 23, 2020

Test is currently excluded by:

// TODO(addaleax): Run this test once it stops failing under ASAN/valgrind.
// Refs: #34731
common.skip('Reference management in N-API leaks memory');
@mhdawson mhdawson mentioned this issue Oct 23, 2020
Open
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
n-api
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@mhdawson
You can’t perform that action at this time.