Skip to content

/ nodejs.dev

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github Superlinter Action #777

Open
designMoreWeb opened this issue Jun 19, 2020 · 1 comment
Open

Github Superlinter Action #777

designMoreWeb opened this issue Jun 19, 2020 · 1 comment
Labels
discussion enhancement question

Comments

@designMoreWeb
Copy link

@designMoreWeb designMoreWeb commented Jun 19, 2020

Github introduced a new action called the Superlinter.
More information on the Linter

Is it a good idea to introduce this action to the existing workflow?

Since the end goal of the linter is to help with:

  • Prevent broken code from being uploaded to the default branch (Usually master)
  • Help establish coding best practices across multiple languages
  • Build guidelines for code layout and format
  • Automate the process to help streamline code reviews

This could also help us with potential code reviews for features and help maintain a standard across the project.
@nschonni
Copy link
Member

@nschonni nschonni commented Jun 19, 2020

Interesting idea, but I think I'm 👎 since we already have a bunch of those linters running in CI, and this would decouple them from the versions people would be using locally. EX: if the package-lock.json version is different from the action, you'd get failures, or passes on CI that might not match your local development.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion enhancement question
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@nschonni @designMoreWeb
You can’t perform that action at this time.