Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42144: Add a missing "goto error;" in the _ssl module #22959

Merged
merged 1 commit into from Oct 25, 2020
Merged

bpo-42144: Add a missing "goto error;" in the _ssl module #22959

merged 1 commit into from Oct 25, 2020

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Oct 25, 2020 •
edited by miss-islington

https://bugs.python.org/issue42144

Automerge-Triggered-By: GH:tiran

@ZackerySpytz ZackerySpytz requested a review from tiran as a code owner Oct 25, 2020
@ZackerySpytz
Copy link
Contributor Author

ZackerySpytz commented Oct 25, 2020

This is trivial enough for "skip news".

tiran
tiran approved these changes Oct 25, 2020
View changes
Copy link
Member

@tiran tiran left a comment

Good catch!

@tiran tiran added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Oct 25, 2020
@miss-islington miss-islington merged commit c32f297 into python:master Oct 25, 2020
3 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Oct 25, 2020

Thanks @ZackerySpytz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Oct 25, 2020

GH-22974 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 25, 2020
@ZackerySpytz @miss-islington
bpo-42144: Add a missing "goto error;" in the _ssl module (pythonGH-2…
677d7b4 
…2959)

(cherry picked from commit c32f297)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Oct 25, 2020

GH-22975 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 25, 2020
@ZackerySpytz @miss-islington
bpo-42144: Add a missing "goto error;" in the _ssl module (pythonGH-2…
a8f4a84 
…2959)

(cherry picked from commit c32f297)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Oct 25, 2020
@miss-islington @ZackerySpytz
bpo-42144: Add a missing "goto error;" in the _ssl module (GH-22959)
8e980ec 
(cherry picked from commit c32f297)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Oct 25, 2020
@miss-islington @ZackerySpytz
bpo-42144: Add a missing "goto error;" in the _ssl module (GH-22959)
83c86cf 
(cherry picked from commit c32f297)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Oct 25, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL8 3.9 has failed when building commit 83c86cf.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/250/builds/98) and take a look at the build logs.
  4. Check if the failure is related to this commit (83c86cf) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/250/builds/98

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

411 tests OK.

10 slowest tests:

  • test_unparse: 4 min 9 sec
  • test_concurrent_futures: 4 min 6 sec
  • test_gdb: 3 min 17 sec
  • test_tokenize: 3 min 15 sec
  • test_peg_generator: 2 min 20 sec
  • test_lib2to3: 2 min 18 sec
  • test_multiprocessing_spawn: 2 min 14 sec
  • test_capi: 2 min 9 sec
  • test_unicodedata: 1 min 38 sec
  • test_asyncio: 1 min 32 sec

1 test altered the execution environment:
test_asyncio

13 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_ossaudiodev
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

Total duration: 6 min 59 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/asyncio/sslproto.py", line 321, in __del__
    self.close()
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/asyncio/sslproto.py", line 316, in close
    self._ssl_protocol._start_shutdown()
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/asyncio/sslproto.py", line 590, in _start_shutdown
    self._abort()
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/asyncio/sslproto.py", line 731, in _abort
    self._transport.abort()
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/asyncio/selector_events.py", line 680, in abort
    self._force_close(None)
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/asyncio/selector_events.py", line 731, in _force_close
    self._loop.call_soon(self._call_connection_lost, exc)
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/asyncio/base_events.py", line 746, in call_soon
    self._check_closed()
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/asyncio/base_events.py", line 510, in _check_closed
    raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@ZackerySpytz @adorilson
bpo-42144: Add a missing "goto error;" in the _ssl module (pythonGH-2…
8fab78f 
…2959)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ZackerySpytz @miss-islington @bedevere-bot @tiran @the-knights-who-say-ni