Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot didn't close issue? #25

Open
Hixie opened this issue Oct 2, 2018 · 16 comments
Open

Bot didn't close issue? #25

Hixie opened this issue Oct 2, 2018 · 16 comments

Comments

@Hixie
Copy link

@Hixie Hixie commented Oct 2, 2018

These issues have been marked appropriately (as far as I can tell) for longer than the configured close period (as far as I can tell) but didn't get closed:

flutter/flutter#9384
flutter/flutter#9385

@RussH
Copy link

@RussH RussH commented Nov 1, 2018

@Hixie I have the same issue. Did you find a fix at-all?

@Hixie
Copy link
Author

@Hixie Hixie commented Nov 1, 2018

Nope. :-(

@gixid192
Copy link

@gixid192 gixid192 commented Dec 3, 2018

Same here :(

@AlexSkorkin
Copy link

@AlexSkorkin AlexSkorkin commented Dec 14, 2018

same here...

@gixid192
Copy link

@gixid192 gixid192 commented Jan 22, 2019

It is working for me now. My problem is I didn't assign the label for the issue.
no-res-result

@RussH
Copy link

@RussH RussH commented Jun 3, 2019

so just to check - is this working now? I've just flagged some issues, I won't find out until the 14 day timer expires

@AlexSkorkin
Copy link

@AlexSkorkin AlexSkorkin commented Jun 3, 2019

It works fine on my side.

@Hixie
Copy link
Author

@Hixie Hixie commented Nov 6, 2019

Seems to not work again. For example: flutter/flutter#20912

@kf6gpe
Copy link

@kf6gpe kf6gpe commented Mar 9, 2020

It's still not working for flutter/flutter reliably --- any update here? Thanks!

cc @helinanever

@mairaw
Copy link

@mairaw mairaw commented Apr 28, 2020

I also recently installed the bot on a new repo and I yet have to see the bot close any issues. I've seen it remove the label when a customer responded, so I know that the bot seems to be configured for my repo. Or does this only apply to labels applied after you configure the bot? If so, I might start seeing issues closed after an additional week or so.

@helinanever
Copy link

@helinanever helinanever commented Apr 30, 2020

The behaviour of the bot in https://github.com/flutter/flutter/issues is still unreliable. The most common issue is that it fails to close issues at the right time (21 days), e.g. flutter/flutter#10593, or closes them later (after 26 days), e.g. flutter/flutter#47619.

Sometimes it also closes when it shouldn't, e.g. flutter/flutter#38976, or doesn't remove the "waiting for.." label after the author replies, e.g. flutter/flutter#53790.

GitHub
Flutter makes it easy and fast to build beautiful apps for mobile and beyond. - flutter/flutter
@Ornias1993
Copy link

@Ornias1993 Ornias1993 commented Aug 29, 2020

@helinanever and @Hixie
You guys do notice you didn't use the recommended syntax in the config file do you?
closeComment: >-
Where the recommended syntax is:
closeComment: >

@Hixie
Copy link
Author

@Hixie Hixie commented Aug 29, 2020

We did not notice at all, good to know.

Hixie added a commit to flutter/flutter that referenced this issue Aug 29, 2020
Let's try updating the configuration as suggested here: probot/no-response#25 (comment)
@Hixie
Copy link
Author

@Hixie Hixie commented Aug 29, 2020

(Though... why would it sometimes work in that case?)

@Ornias1993
Copy link

@Ornias1993 Ornias1993 commented Aug 29, 2020

(Though... why would it sometimes work in that case?)

Thats a very good question! For which i've no answer...
Don't expect this to magically fix your problem, but at least we might be able to exclude this... :)

@mairaw
Copy link

@mairaw mairaw commented Aug 29, 2020

Just FYI, since I posted, the bot started working for my repo. After a couple of weeks waiting to see if the bot would kick off (I had the period set to 14 days), I changed it to 10 and then it started working all of the sudden.

kf6gpe added a commit to kf6gpe/flutter that referenced this issue Sep 1, 2020
@kf6gpe kf6gpe mentioned this issue Sep 1, 2020
8 of 12 tasks complete
fluttergithubbot pushed a commit to flutter/flutter that referenced this issue Sep 2, 2020
mingwandroid added a commit to mingwandroid/flutter that referenced this issue Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants
You can’t perform that action at this time.