Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More bazel tests #16976

Merged
merged 24 commits into from Apr 30, 2020
Merged

More bazel tests #16976

merged 24 commits into from Apr 30, 2020

Conversation

filipesilva
Copy link
Contributor

@filipesilva filipesilva commented Feb 14, 2020

No description provided.

@filipesilva filipesilva force-pushed the more-bazel-tests branch 9 times, most recently from 267a0c5 to 227aca5 Compare Mar 11, 2020
@filipesilva filipesilva force-pushed the more-bazel-tests branch 12 times, most recently from ffb976f to 0e1b959 Compare Mar 19, 2020
@filipesilva filipesilva force-pushed the more-bazel-tests branch 8 times, most recently from ed90a8b to 7c72c87 Compare Mar 24, 2020
filipesilva and others added 22 commits Apr 30, 2020
@filipesilva
fix(@ngtools/webpack): export VirtualFileSystemDecorator type
44dc350 
We shouldn't need to export this, but webpack-rollup-loader uses it.
@filipesilva
fix(@ngtools/webpack): remove internal markers
8d3ae1a 
With these in, we can't access the properties from other Bazel targets.
@filipesilva
build: don't copy root package test folders
66de588
@filipesilva
build: use rules_nodejs 1.6.0 features
f6d626a 
Contains fixes related to the symlink behaviour inside of bazel. Without it, webpack needs to be configured to be aware of symlinks and preserve the paths.
@filipesilva
test(@angular-devkit/build-webpack): build and test with Bazel
3108106
@filipesilva
test(@angular-devkit/build-angular): build and test with Bazel
15d84f1
@filipesilva
test(@angular-devkit/build-ng-packagr): build and test with Bazel
2a9ae14
@filipesilva
build: add missing npm_package_archive targets
43a2dd1
@filipesilva
test(@angular/cli): add npm_integration_test
7f72c01
@filipesilva
build: update yarn lock
58e59e4
@filipesilva
test: remove non-bazel test setup
cea0326
@filipesilva
ci: use xlarge for bazel tests
59744c0
@gregmagolan @filipesilva
build: add webdriver-manager update & ngcc to postinstall
3185ce8 
This is required so that yarn_install can add all generated & downloaded files to the generated bazel filegroups
@filipesilva
docs: add bazel jasmine_node_test debug information
903839a
@gregmagolan @filipesilva
build: run tests depending on webdriver-manager locally
c73a378
@gregmagolan @filipesilva
build: use no-remote-exec tag so test still runs in sandbox
ed18067 
Turns out there is a linker bug with no sandbox.
@filipesilva
ci: update required status checks
35834f4
@filipesilva
build: use @bazel/bazelisk
e94f786
@filipesilva
build: use ts_library macro with common defaults
903d44f
@filipesilva
build: add rbe_ubuntu1604-angular docker permissions
03b5776
@gregmagolan @filipesilva
build: exclude nested node_modules laid out by yarn workspaces from a…
cd33c21 
…ll globs
@filipesilva
ci: add reasoning behind bazel jobs depending on build
cbead4e
@dgp1130 dgp1130 merged commit 1d2e7bb into angular:master Apr 30, 2020
13 of 14 checks passed
@dgp1130
Copy link
Collaborator

dgp1130 commented Apr 30, 2020

Per #16976 (comment) merged despite the pending statuses for removed checks.

Also updated status checks to drop test-large, test-large-ve, and build-bazel and added integration as suggested. I'll rebase existing PRs and verify they pick up the new settings.

@gregmagolan
Copy link
Contributor

gregmagolan commented Apr 30, 2020

🎉 Nice work @filipesilva

@filipesilva
Copy link
Contributor Author

filipesilva commented May 1, 2020

@gregmagolan you know a lot of it was you :D

@jkrems jkrems mentioned this pull request May 6, 2020
Closed
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jun 1, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gregmagolan gregmagolan

@alan-agius4 alan-agius4

@clydin clydin

Assignees
No one assigned
Labels
action: merge PR author is ready for this to merge target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@filipesilva @googlebot @gregmagolan @alan-agius4 @dgp1130 @clydin