Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/list): exclude icons from harness getText result #20845

Merged
merged 1 commit into from Oct 28, 2020
Merged

fix(material/list): exclude icons from harness getText result #20845

merged 1 commit into from Oct 28, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 21, 2020

Excludes icons and avatars from the MatListItemHarnessBase.getText result.

Fixes #20812.

@crisbeto crisbeto added P3 target: patch labels Oct 21, 2020
@google-cla google-cla bot added the cla: yes label Oct 21, 2020
@crisbeto
fix(material/list): exclude icons from harness getText result
07556b4 
Excludes icons and avatars from the `MatListItemHarnessBase.getText` result.

Fixes angular#20812.
@crisbeto crisbeto force-pushed the 20812/list-harness-exclude branch from 5ebe26c to 07556b4 Compare Oct 21, 2020
jelbourn
jelbourn approved these changes Oct 21, 2020
View changes
Copy link
Member

@jelbourn jelbourn left a comment

LGTM

@jelbourn jelbourn added the merge ready label Oct 21, 2020
@wagnermaciel wagnermaciel merged commit dfdd422 into angular:master Oct 28, 2020
16 checks passed
wagnermaciel pushed a commit that referenced this issue Oct 28, 2020
@crisbeto @wagnermaciel
fix(material/list): exclude icons from harness getText result (#20845)
aec12b6 
Excludes icons and avatars from the `MatListItemHarnessBase.getText` result.

Fixes #20812.

(cherry picked from commit dfdd422)
wagnermaciel pushed a commit that referenced this issue Oct 28, 2020
@crisbeto @wagnermaciel
fix(material/list): exclude icons from harness getText result (#20845)
8638456 
Excludes icons and avatars from the `MatListItemHarnessBase.getText` result.

Fixes #20812.

(cherry picked from commit dfdd422)
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Nov 28, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn

@devversion devversion

Assignees

@annieyw annieyw

Labels
cla: yes merge ready P3 target: patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(MatNavListItemHarness): getText() needs to exclude icons
4 participants
@crisbeto @jelbourn @annieyw @wagnermaciel