presubmit.yml: Set skip_use_bazel_version_for_test: true #347
Conversation
This will fix recent test breakage in Bazel downstream: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1588#91ed10dd-2b13-4cee-99cc-88a2e8e58a31 Similar issue and fix: bazelbuild/bazel#10554 bazelbuild/rules_nodejs#1538
|
Ping, can we get this merged? |
|
Thanks for the fix. Makes sense that we've inherited this problem by adopting the integration test system of |
thundergolfer
merged commit e1277ff
into
bazelbuild:master
2 checks passed
2 checks passed
cla/google
All necessary CLAs are signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This will fix recent test breakage in Bazel downstream:
https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1588#91ed10dd-2b13-4cee-99cc-88a2e8e58a31
Similar issue and fix:
bazelbuild/bazel#10554
bazelbuild/rules_nodejs#1538
PR Checklist
Please check if your PR fulfills the following requirements:
.parfiles. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information