Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upconsole: use more primordials #35734
Open
+44
−28
Conversation
This comment has been hidden.
This comment has been hidden.
|
Why am I getting |
|
My guess is that the method is not available to primordials because it can be disabled in V8 with |
This comment was marked as off-topic.
This comment was marked as off-topic.
Interesting. Well I guess we'll have to refrain from using it in node core for the time being then… |
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Backport requested because optional chaining is not available on Node.js 12.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes