Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upadd a subsystems header in pull-requests.md #35718
Open
+15
−14
Conversation
|
Review requested: |
|
Looks good to me. Some optional ideas:
|
Codecov Report
@@ Coverage Diff @@
## master #35718 +/- ##
=======================================
Coverage 96.40% 96.40%
=======================================
Files 220 220
Lines 73675 73676 +1
=======================================
+ Hits 71025 71028 +3
+ Misses 2650 2648 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes