Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update gyp-next to v0.6.2 #35690

Merged
merged 0 commits into from Oct 17, 2020
Merged

tools: update gyp-next to v0.6.2 #35690

merged 0 commits into from Oct 17, 2020

Conversation

targos
Copy link
Member

@targos targos commented Oct 17, 2020

No description provided.

@nodejs-github-bot nodejs-github-bot added build tools labels Oct 17, 2020
@targos
Copy link
Member Author

@targos targos commented Oct 17, 2020

Please 👍 to fast-track. We need this for #35415

@targos targos added fast-track request-ci labels Oct 17, 2020
@github-actions github-actions bot removed the request-ci label Oct 17, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Oct 17, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33687/

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Oct 17, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33688/

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Oct 17, 2020 •
edited by Trott

CI: https://ci.nodejs.org/job/node-test-pull-request/33689/ ✅

aduh95
aduh95 approved these changes Oct 17, 2020
View changes
Copy link
Contributor

@aduh95 aduh95 left a comment

RSLGTM

Trott
Trott approved these changes Oct 17, 2020
View changes
Copy link
Member

@Trott Trott left a comment

Rubber-stamp LGTM

@Trott
Copy link
Member

@Trott Trott commented Oct 17, 2020

Landed in 35a6946

@Trott Trott closed this Oct 17, 2020
@Trott Trott merged commit 35a6946 into nodejs:master Oct 17, 2020
@targos targos deleted the gyp-next branch Oct 17, 2020
@MylesBorins
Copy link
Member

@MylesBorins MylesBorins commented Nov 24, 2020

As mentioned in #35635 (comment) should we be backporting this to v14.x LTS?

@MylesBorins MylesBorins added backport-requested-v14.x and removed backport-requested-v14.x labels Nov 24, 2020
BethGriggs added a commit that referenced this issue Dec 8, 2020
@targos @BethGriggs
tools: update gyp-next to v0.6.2
985efdf 
PR-URL: #35690
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
richardlau added a commit to richardlau/node-1 that referenced this issue Aug 18, 2021
@targos @richardlau
tools: update gyp-next to v0.6.2
dcaa7d2 
PR-URL: nodejs#35690
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott

@aduh95 aduh95

Assignees
No one assigned
Labels
build fast-track tools
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
5 participants
@targos @nodejs-github-bot @Trott @MylesBorins @aduh95