Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add chapter on control flow (#608) #609

Open
wants to merge 1 commit into
base: master
from

Conversation

@aug2uag
Copy link

aug2uag commented Apr 26, 2020

Description

Chapter on control flow was added.

Related Issues

Addresses #608

@aug2uag aug2uag force-pushed the aug2uag:master branch from 45784ce to 63cb407 Apr 26, 2020
Copy link
Member

alexandrtovmach left a comment

@aug2uag package-lock.json shouldn't be updated, if your changes related to docs only

@aug2uag
Copy link
Author

aug2uag commented Apr 26, 2020

@alexandrtovmach
Copy link
Member

alexandrtovmach commented Apr 26, 2020

@aug2uag Better to split not related changes to separate PRs, and I don't see any chore commit

@aug2uag
Copy link
Author

aug2uag commented Apr 26, 2020

@aug2uag aug2uag force-pushed the aug2uag:master branch 5 times, most recently from 3b97c7b to a964599 Apr 26, 2020
Copy link
Member

MylesBorins left a comment

The first sentence in this doc seems to imply the it might have been copied from somewhere else. I'm going to hold off on doing a full review until that has been resolved.

Please feel free to dismiss this request for changes if the copy is indeed original

section: Getting Started
---

I'm presenting material that's helped me greatly in the past from [Mixu's Node.js Book](http://book.mixu.net/node/ch7.html).

This comment has been minimized.

Copy link
@MylesBorins

MylesBorins Apr 28, 2020

Member

Is this a copy paste of the material from that book?

If so we probably can't land it.

If it is originally copy we likely want to modify this to not use I'm, as the docs are generally not written in the first person.

Suggested change
I'm presenting material that's helped me greatly in the past from [Mixu's Node.js Book](http://book.mixu.net/node/ch7.html).
The material in this post has been heavily inspired by [Mixu's Node.js Book chapter 7](http://book.mixu.net/node/ch7.html).

This comment has been minimized.

Copy link
@aug2uag

aug2uag May 1, 2020

Author

sorry i had missed your suggestion, made the update just now

@aug2uag
Copy link
Author

aug2uag commented Apr 28, 2020

@aug2uag
Copy link
Author

aug2uag commented May 1, 2020

@MylesBorins copy is original, @alexandrtovmach updates are in

@aug2uag aug2uag force-pushed the aug2uag:master branch 3 times, most recently from 2bed425 to da6c348 May 1, 2020
Copy link
Member

alexandrtovmach left a comment

I'm not a right person to make a content reviews, so I just dismiss my requested changes with this comment

@alexandrtovmach alexandrtovmach dismissed their stale review May 1, 2020

Dismissed

Copy link
Member

Trott left a comment

This needs someone to give it a good copyedit before it is publishable. I noted a few things, but I can see that it's going to be a lot. Someone needs to review the content too, of course.

section: Getting Started
---

The material in this post are heavily inspired by [Mixu's Node.js Book](http://book.mixu.net/node/ch7.html).

This comment has been minimized.

Copy link
@Trott

Trott May 1, 2020

Member
Suggested change
The material in this post are heavily inspired by [Mixu's Node.js Book](http://book.mixu.net/node/ch7.html).
The material in this post is heavily inspired by [Mixu's Node.js Book](http://book.mixu.net/node/ch7.html).

The material in this post are heavily inspired by [Mixu's Node.js Book](http://book.mixu.net/node/ch7.html).

At it's core, JavaScript is designed to be non-blocking on the "main" thread only. Other threads provide the ability to run tasks asynchronously at the cost of control.

This comment has been minimized.

Copy link
@Trott

Trott May 1, 2020

Member
Suggested change
At it's core, JavaScript is designed to be non-blocking on the "main" thread only. Other threads provide the ability to run tasks asynchronously at the cost of control.
At its core, JavaScript is designed to be non-blocking on the "main" thread only. Other threads provide the ability to run tasks asynchronously at the cost of control.

This creates some unique constraints that only a functional style of programming can cure. This is where "callbacks" come in to the picture.

You may find yourself in "callback hell"

This comment has been minimized.

Copy link
@Trott

Trott May 1, 2020

Member

This sentence needs punctuation.

@aug2uag aug2uag force-pushed the aug2uag:master branch 2 times, most recently from 46e3f73 to 0d82e68 May 6, 2020
@aug2uag aug2uag force-pushed the aug2uag:master branch from 0d82e68 to 4b9273e May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.