Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign updocs: Add chapter on control flow (#608) #609
Conversation
|
@aug2uag |
|
Hi, there were audit fixes in npm. One commit is marked as a chore and
squashed in. What would you like me to do?
…On Sun, Apr 26, 2020, 9:21 AM Alexandr Tovmach ***@***.***> wrote:
***@***.**** requested changes on this pull request.
@aug2uag <https://github.com/aug2uag> package-lock.json shouldn't be
updated, if your changes related to docs only
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#609 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOQFC44F7DOWPL25LNPPCTRORNQVANCNFSM4MRDNPKQ>
.
|
|
@aug2uag Better to split not related changes to separate PRs, and I don't see any |
|
Got it. Ya the commit's squashed, if you expand the last commit you'll see
the chore there. I'll address this ASAP
…On Sun, Apr 26, 2020 at 1:28 PM Alexandr Tovmach ***@***.***> wrote:
@aug2uag <https://github.com/aug2uag> Better to split not related changes
to separate PRs, and I don't see any chore commit
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#609 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOQFC44DBZGYR6JZVIEFRTROSKPJANCNFSM4MRDNPKQ>
.
|
3b97c7b
to
a964599
|
The first sentence in this doc seems to imply the it might have been copied from somewhere else. I'm going to hold off on doing a full review until that has been resolved. Please feel free to dismiss this request for changes if the copy is indeed original |
| section: Getting Started | ||
| --- | ||
|
|
||
| I'm presenting material that's helped me greatly in the past from [Mixu's Node.js Book](http://book.mixu.net/node/ch7.html). |
This comment has been minimized.
This comment has been minimized.
MylesBorins
Apr 28, 2020
Member
Is this a copy paste of the material from that book?
If so we probably can't land it.
If it is originally copy we likely want to modify this to not use I'm, as the docs are generally not written in the first person.
| I'm presenting material that's helped me greatly in the past from [Mixu's Node.js Book](http://book.mixu.net/node/ch7.html). | |
| The material in this post has been heavily inspired by [Mixu's Node.js Book chapter 7](http://book.mixu.net/node/ch7.html). |
This comment has been minimized.
This comment has been minimized.
|
The copy is original. That referenced chapter is a great read though-- one
chapter 17 about control flow. Review would be 5 mins if necessary from any
third party. I'm here in case I can do anything to help
…On Mon, Apr 27, 2020 at 10:29 PM Myles Borins ***@***.***> wrote:
*@MylesBorins* requested changes on this pull request.
The first sentence in this doc seems to imply the it might have been
copied from somewhere else. I'm going to hold off on doing a full review
until that has been resolved.
Please feel free to dismiss this request for changes if the copy is indeed
original
------------------------------
In src/documentation/0056-node-control-flow/index.md
<#609 (comment)>:
> @@ -0,0 +1,237 @@
+---
+title: Asynchronous flow control
+description: 'JavaScript control flow is all about callback handling. Here are strategies to help your development.'
+authors: aug2uag
+section: Getting Started
+---
+
+I'm presenting material that's helped me greatly in the past from [Mixu's Node.js Book](http://book.mixu.net/node/ch7.html).
Is this a copy paste of the material from that book?
If so we probably can't land it.
If it is originally copy we likely want to modify this to not use I'm, as
the docs are generally not written in the first person.
|
|
@MylesBorins copy is original, @alexandrtovmach updates are in |
2bed425
to
da6c348
|
I'm not a right person to make a content reviews, so I just dismiss my requested changes with this comment |
|
This needs someone to give it a good copyedit before it is publishable. I noted a few things, but I can see that it's going to be a lot. Someone needs to review the content too, of course. |
| section: Getting Started | ||
| --- | ||
|
|
||
| The material in this post are heavily inspired by [Mixu's Node.js Book](http://book.mixu.net/node/ch7.html). |
This comment has been minimized.
This comment has been minimized.
Trott
May 1, 2020
Member
| The material in this post are heavily inspired by [Mixu's Node.js Book](http://book.mixu.net/node/ch7.html). | |
| The material in this post is heavily inspired by [Mixu's Node.js Book](http://book.mixu.net/node/ch7.html). |
|
|
||
| The material in this post are heavily inspired by [Mixu's Node.js Book](http://book.mixu.net/node/ch7.html). | ||
|
|
||
| At it's core, JavaScript is designed to be non-blocking on the "main" thread only. Other threads provide the ability to run tasks asynchronously at the cost of control. |
This comment has been minimized.
This comment has been minimized.
Trott
May 1, 2020
Member
| At it's core, JavaScript is designed to be non-blocking on the "main" thread only. Other threads provide the ability to run tasks asynchronously at the cost of control. | |
| At its core, JavaScript is designed to be non-blocking on the "main" thread only. Other threads provide the ability to run tasks asynchronously at the cost of control. |
|
|
||
| This creates some unique constraints that only a functional style of programming can cure. This is where "callbacks" come in to the picture. | ||
|
|
||
| You may find yourself in "callback hell" |
This comment has been minimized.
This comment has been minimized.
46e3f73
to
0d82e68
aug2uag commentedApr 26, 2020
Description
Chapter on control flow was added.
Related Issues
Addresses #608