Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total regression in codecov coverage report looks suspicious #35759

Closed
puzpuzpuz opened this issue Oct 22, 2020 · 3 comments
Closed

Total regression in codecov coverage report looks suspicious #35759

puzpuzpuz opened this issue Oct 22, 2020 · 3 comments
Labels

Comments

@puzpuzpuz
Copy link
Member

@puzpuzpuz puzpuzpuz commented Oct 22, 2020

Got an automated coverage report on #35753. The reported coverage regression is estimated as -8.50% which is very suspicious, considering that the changes made by the PR are relatively small and tests are included. Impacted files list also includes mostly unrelated files. Is it possible that there is something wrong with codecov configuration or the service itself?

See #35753 (comment) and https://codecov.io/gh/nodejs/node/pull/35753 for more details

@puzpuzpuz puzpuzpuz added the test label Oct 22, 2020
@richardlau
Copy link
Member

@richardlau richardlau commented Oct 22, 2020

#35670 (comment) is probably relevant.

cc @bcoe

@bcoe
Copy link
Member

@bcoe bcoe commented Oct 23, 2020

@puzpuzpuz @richardlau I'm not 100% sure the reason, but codecov.io seems to get a bit confused about the order that commits land to our main branch:

Screen Shot 2020-10-22 at 6 59 38 PM

☝️ it's expected that coverage will be about 87% now, but it doesn't look like codecov.io has caught up yet.

I believe the notifications will stabilize once it catches up.

@puzpuzpuz
Copy link
Member Author

@puzpuzpuz puzpuzpuz commented Oct 23, 2020

@bcoe thanks for the clarification. It makes sense. I'm going to hide the codecov message and close this issue. Feel free to reopen it if you think it's necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.