Enhance the !server command. by kosayoda · Pull Request #1166 · python-discord/bot

kosayoda · 2020-09-21T15:32:20Z

The !server command is now more compact, and has more information.

In a regular channel

In a moderation channel

For contrast, the old embed:

I have no idea what I'm doing with the test.

Rather than do two passes over the channels, a single loop is used to collect all the channel counts into a single dictionary. The get_channel_type_counts method now returns a dictionary of channel to count, allowing the caller liberty to format the values.

Includes useful information like the number of nominated/watched members, number of unverified members, defcon status etc. Will not show up if the command is ran outside of a moderation channel.

Numerlor · 2020-09-21T21:26:18Z

The roles count feels a bit out of place under the member counts, maybe the description "header" would be more fitting for it?
Are the features necessary for the (user) embed? The information they expose feels unnecessary to know in almost all cases and they clutter it quite a bit

kosayoda · 2020-09-22T15:54:29Z

The roles count <-- snip --> description "header" would be more fitting for it?

That's a good idea, and it would make some code a tad bit clearer.

Are the features necessary for the (user) embed?

By features I assume you mean the server features in the embed description. I agree, it gets quite long in the actual server.

@python-discord/core-developers I'll be removing the features section from the embed outside of a moderation channel if no one has an objection to it.

Akarys42 · 2020-09-23T09:49:19Z

Maybe we should also add a count for the missing roles: core devs, event team, python community and partners ?

thomaspet · 2020-09-29T11:02:16Z

Does the statuses look good with a big number on all 4? even on mobile?
like online, dnd, away and offline all being 10,000 at least.. offline and online might one day both me 100,000 as well.

thomaspet

Looks good to me, if we need the presence? I believe thats up for debate

thomaspet · 2020-09-29T11:06:01Z

+            channel.overwrites_for(guild.get_role(staff_role)).read_messages is True
+            and channel.overwrites_for(guild.default_role).read_messages is False


Not against verbosity, but just making sure it was intended, and not be

Suggested change

channel.overwrites_for(guild.get_role(staff_role)).read_messages is True

and channel.overwrites_for(guild.default_role).read_messages is False

channel.overwrites_for(guild.get_role(staff_role)).read_messages

and not channel.overwrites_for(guild.default_role).read_messages

overwrites_for returns a PermissionOverwrite object.

Unlike a regular Permissions, the default value of a permission is equivalent to None and not False. Setting a value to False is explicitly denying that permission, while setting a value to True is explicitly allowing that permission.

An implicit check would also count the default permission as a deny, hence we explicitly check for True or False. I'm not resolving this yet since I think this could be clarified a bit more in the comment.

kwzrd · 2020-10-03T13:54:41Z

This PR will have conflicts with #1196 and should probably wait until we start using d.py 1.5; some of the presence tracking will no longer be possible.

Xithrius · 2020-12-20T06:22:44Z

Updating:

The master branch now runs off of discord.py 1.5.1, and #1196 has been merged.

We do not have the Developers role anymore, so there's no such thing as verified/unverified members.

coveralls · 2021-01-15T07:03:14Z

Coverage decreased (-0.1%) to 56.607% when pulling e658e23 on feat/info/server-cmd-enhancements into abe439e on master.

Xithrius

The code looks good to me, and I'm really into this new embed.

But should we have defcon days as None instead of -?

kosayoda · 2021-01-19T10:09:34Z

But should we have defcon days as None instead of -?

I'm fine with either, - gives me a more "not applicable" feel than None though

Xithrius · 2021-01-19T16:36:07Z

I see. It does look fine to me as of now.

If the staff doesn't like it for some reason, it can always be changed.

kosayoda added 6 commits September 21, 2020 16:56

Move Channels information to embed field.

4615571

Move member status information to embed field.

6b42380

Simplify channel counting.

78cac10

Rather than do two passes over the channels, a single loop is used to collect all the channel counts into a single dictionary. The get_channel_type_counts method now returns a dictionary of channel to count, allowing the caller liberty to format the values.

Move member count to embed field.

dfb8568

Add more role information to server embed.

0f074d5

Add extended information to !server.

dcc1f54

Includes useful information like the number of nominated/watched members, number of unverified members, defcon status etc. Will not show up if the command is ran outside of a moderation channel.

kosayoda requested a review from a team as a code owner September 21, 2020 15:32

kosayoda requested review from GhostofGoes and dementati and removed request for a team September 21, 2020 15:32

ghost added the needs 2 approvals label Sep 21, 2020

kosayoda added a: frontend Related to output and formatting a: information Related to information commands: (doc, help, information, reddit, site, tags) p: 3 - low Low Priority labels Sep 21, 2020

kosayoda added 4 commits September 23, 2020 11:54

Move number of roles to embed description.

1854375

Add owners count to server embed

2c2dbe4

Only show server features in certain channels.

13df744

Update relevant channels for features.

0b83a7c

MarkKoz added the t: feature New feature or request label Sep 24, 2020

thomaspet reviewed Sep 29, 2020

View reviewed changes

Update !server with discord 1.5 presence changes.

4e6f043

kosayoda added 2 commits January 15, 2021 13:44

Merge branch 'master' into feat/info/server-cmd-enhancements

292885a

Remove unverified member information.

6e0d810

We do not have the Developers role anymore, so there's no such thing as verified/unverified members.

kosayoda requested a review from Akarys42 as a code owner January 15, 2021 06:59

kosayoda requested review from Den4200 and mbaruh as code owners January 15, 2021 06:59

Xithrius reviewed Jan 17, 2021

View reviewed changes

Merge branch 'master' into feat/info/server-cmd-enhancements

dbe0643

Xithrius approved these changes Jan 19, 2021

View reviewed changes

Numerlor suggested changes Jan 20, 2021

View reviewed changes

mbaruh requested changes Jan 20, 2021

View reviewed changes

Comment thread bot/exts/info/information.py Outdated

Comment thread bot/exts/info/information.py Outdated

Comment thread bot/exts/info/information.py Outdated

kosayoda added 5 commits January 23, 2021 17:51

Extract is_staff_channel to a utility function.

ca38700

Use helper function to determine mod channel.

a7c6d57

Reduce unnecessary line splits and parameters.

8cdee21

Handle unloaded cogs when retrieving server info.

f612a26

Merge branch 'master' into feat/info/server-cmd-enhancements

87e4b09

Numerlor reviewed Jan 23, 2021

View reviewed changes

Comment thread bot/exts/info/information.py Outdated

Remove redundant parenthesis.

43cdae4

Numerlor approved these changes Jan 24, 2021

View reviewed changes

Xithrius requested a review from mbaruh January 24, 2021 07:32

Merge branch 'master' into feat/info/server-cmd-enhancements

e658e23

Xithrius added needs 1 approval and removed needs 2 approvals labels Jan 24, 2021

Xithrius approved these changes Jan 24, 2021

View reviewed changes

mbaruh approved these changes Jan 24, 2021

View reviewed changes

mbaruh merged commit 8ec2a4d into master Jan 24, 2021

mbaruh deleted the feat/info/server-cmd-enhancements branch January 24, 2021 17:20

		channel.overwrites_for(guild.get_role(staff_role)).read_messages is True
		and channel.overwrites_for(guild.default_role).read_messages is False

Uh oh!

Conversation

kosayoda commented Sep 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

In a regular channel

In a moderation channel

Uh oh!

Numerlor commented Sep 21, 2020

Uh oh!

kosayoda commented Sep 22, 2020

Uh oh!

Akarys42 commented Sep 23, 2020

Uh oh!

thomaspet commented Sep 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thomaspet left a comment

Choose a reason for hiding this comment

Uh oh!

thomaspet Sep 29, 2020

Choose a reason for hiding this comment

Uh oh!

kosayoda Sep 30, 2020

Choose a reason for hiding this comment

Uh oh!

kwzrd commented Oct 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Xithrius commented Dec 20, 2020

Uh oh!

coveralls commented Jan 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Xithrius left a comment

Choose a reason for hiding this comment

Uh oh!

kosayoda commented Jan 19, 2021

Uh oh!

Xithrius commented Jan 19, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

kosayoda commented Sep 21, 2020 •

edited

Loading

thomaspet commented Sep 29, 2020 •

edited

Loading

kwzrd commented Oct 3, 2020 •

edited

Loading

coveralls commented Jan 15, 2021 •

edited

Loading