Skip to content

/ flutter

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The tooltips component does not fit the desktop #68601

Closed
fanchou opened this issue Oct 20, 2020 · 2 comments
Closed

The tooltips component does not fit the desktop #68601

fanchou opened this issue Oct 20, 2020 · 2 comments
Labels
P4 a: desktop a: fidelity a: quality f: material design found in release: 1.24 framework has reproducible steps

Comments

@fanchou
Copy link

@fanchou fanchou commented Oct 20, 2020

Here the tooltip material design document

image

I think Tooltip is very import for desktop, the code just for mobile.

image
@pedromassangocode
Copy link
Member

@pedromassangocode pedromassangocode commented Oct 20, 2020

Hi @fanchou
Thanks for filling this issue.

This issue is reproducible with the latest master channel.
It defaults to the Mobile spec and we need to make sure this follows the Material Design specs for different platforms.

flutter/packages/flutter/lib/src/material/tooltip.dart

Line 173 in dde2044

static const double _defaultTooltipHeight = 32.0;

Cc @HansMuller

flutter doctor -v 
[✓] Flutter (Channel master, 1.24.0-2.0.pre.86, on Mac OS X 10.15.7 19H2 darwin-x64, locale
    en)
    • Flutter version 1.24.0-2.0.pre.86 at /Users/pedromassango/dev/SDKs/flutter_master
    • Framework revision dde20448f7 (8 hours ago), 2020-10-20 00:59:56 -0400
    • Engine revision ea2aea1c61
    • Dart version 2.11.0 (build 2.11.0-234.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at /Users/pedromassango/Library/Android/sdk
    • Platform android-30, build-tools 30.0.1
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.0.1, Build version 12A7300
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] IntelliJ IDEA Community Edition (version 2020.2.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 50.0
    • Dart plugin version 202.7319.5

[✓] VS Code (version 1.50.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.15.1

[✓] Connected device (4 available)
    • iPhone 11 Pro Max (mobile) • 913ADC1E-400E-4AA0-8302-D955869FF1C9 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-13-5 (simulator)
    • macOS (desktop)            • macos                                • darwin-x64     • Mac
      OS X 10.15.7 19H2 darwin-x64
    • Web Server (web)           • web-server                           • web-javascript •
      Flutter Tools
    • Chrome (web)               • chrome                               • web-javascript •
      Google Chrome 86.0.4240.80

• No issues found!
@xu-baolin
Copy link
Contributor

@xu-baolin xu-baolin commented Oct 21, 2020

I am currently working on this.
@xu-baolin xu-baolin mentioned this issue Oct 21, 2020
Merged
@gspencergoog gspencergoog added the P4 label Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P4 a: desktop a: fidelity a: quality f: material design found in release: 1.24 framework has reproducible steps
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Apply Desktop specs for Tooltip
5 participants
@stuartmorgan @fanchou @gspencergoog @xu-baolin @pedromassangocode
You can’t perform that action at this time.